Switch to more secure cbor library #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsondav
requested review from
se3000,
j16r and
spooktheducks
and removed request for
se3000
samsondav
force-pushed
the
chore/cln-01-fix-cbor-serialisation-bug-#171337812
branch
from
5cd08e6 to
ace7e53
Compare
|
@samsondav Would you mind adding links or a summary of how/why this new library is more secure? |
|
@spooktheducks yup, I suggest starting with the readme here: https://github.com/fxamacker/cbor The project is well fuzz tested and its explicit goal is to address the multiple security issues in the old codec library we were using. |
|
NOTE: We should cut another release once this is in. |
j16r
approved these changes
Feb 26, 2020
This was referenced Mar 17, 2020
Closed
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://www.pivotaltracker.com/story/show/171337812