Skip to content

Conversation

@chainchad
Copy link
Collaborator

@chainchad chainchad commented Feb 15, 2022

See docs for the path based filtering on GitHub actions.

The goal is to prevent a PR that only changes core/ files from executing a workflow that runs contracts/ tests, for example.

The current changes:

  • Only run solidity tests when contracts/ are changed
  • Only run frontend tests when operator_ui/ is changed
  • Go dependency checks only when go modules are changed
  • Go linting only when .go files are changed

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@chainchad chainchad force-pushed the feature/28874-gha-workflow-path-filter branch from cc35b73 to 0d060bd Compare February 15, 2022 22:05
@chainchad chainchad requested a review from a team February 16, 2022 16:09
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good idea!

vyzaldysanchez
vyzaldysanchez previously approved these changes Feb 16, 2022
HenryNguyen5
HenryNguyen5 previously approved these changes Feb 17, 2022
@chainchad chainchad force-pushed the feature/28874-gha-workflow-path-filter branch from 4beaf1a to 2a7264c Compare February 18, 2022 16:56
@cl-homu
Copy link
Contributor

cl-homu commented Feb 24, 2022

☔ The latest upstream changes (presumably b07ed85) made this pull request unmergeable. Please resolve the merge conflicts.

@chainchad chainchad force-pushed the feature/28874-gha-workflow-path-filter branch from ff24eb6 to bd5393f Compare February 24, 2022 20:19
@chainchad chainchad force-pushed the feature/28874-gha-workflow-path-filter branch from bd5393f to 47770b3 Compare February 24, 2022 20:22
@chainchad chainchad merged commit 516a423 into develop Feb 24, 2022
@chainchad chainchad deleted the feature/28874-gha-workflow-path-filter branch February 24, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants