Skip to content

core/logger: add critical color; dedupe #6093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmank88 merged 1 commit into from
Feb 28, 2022
Merged

core/logger: add critical color; dedupe #6093

jmank88 merged 1 commit into from
Feb 28, 2022

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Feb 28, 2022

Screenshot from 2022-02-28 15-03-18

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2022

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 added the ready for review PR is ready for code review label Feb 28, 2022
@jmank88 jmank88 merged commit 6eea189 into develop Feb 28, 2022
@jmank88 jmank88 deleted the pretty-colors branch February 28, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@samsondav samsondav Awaiting requested review from samsondav

@essamhassan essamhassan Awaiting requested review from essamhassan

Assignees

No one assigned

Labels

ready for review PR is ready for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmank88 @vyzaldysanchez