Various fixes for localFunctionsTestnet
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuphJr
changed the title
localFunctionsTestnet
zeuslawyer
reviewed
Sep 12, 2023
| * @param callbackGasLimit Maximum amount of gas used to call the inherited `handleOracleFulfillment` method | ||
| */ | ||
| function sendEncodedRequest( | ||
| bytes calldata encodedRequest, |
There was a problem hiding this comment.
nit: for consistency this should perhaps be requestDataCBOR or something similar
There was a problem hiding this comment.
The contract is copied, so I would prefer to leave this as-is
zeuslawyer
approved these changes
Sep 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coordinator1tolocal-functions-testnet/test