implemented hierarchal clustering #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whenever I create a certain n amount of clusters, the labels returned by this implementation and sklearn start to deviate. Is it because of the difference in numeric precision with the Python ml libraries? |
|
My Python implementation works perfectly. |
|
I will take a look. For now you can compare with this implementation https://github.com/rom1mouret/catclustering |
Mec-iS
reviewed
Jun 25, 2025
| @@ -4,5 +4,6 @@ | |||
| //! are more similar to other data points in the same group than those in other groups. In simple words, the aim is to segregate groups with similar traits and assign them into clusters. | |||
|
|
|||
| pub mod dbscan; | |||
| pub mod hierarchal; | |||
There was a problem hiding this comment.
typo: hierarchical
also better to use agglomerative
|
@DanielLacina as a pairing algorithm please use fastpair as it is implemented in the pairing module |
|
thanks |
|
Do you think we should add a linkage attribute to the FastPair struct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.