implement icon parameter for alert rpc #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmi only cares about the image path svg wrap no longer wraps an svg, change name remove nested svg property
jacobkeeler
reviewed
Jul 17, 2019
jacobkeeler
reviewed
Jul 17, 2019
jacobkeeler
approved these changes
Jul 17, 2019
|
Also, should add this image field to UI capabilities |
jacobkeeler
requested changes
Jul 24, 2019
jacobkeeler
approved these changes
Jul 25, 2019
# Conflicts: # build/bundle.js
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #0177