Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for template title parameter #178

Merged
merged 11 commits into from
Jul 30, 2019
Merged

Add support for template title parameter #178

merged 11 commits into from
Jul 30, 2019

Conversation

ShobhitAd
Copy link
Contributor

@ShobhitAd ShobhitAd commented Jul 16, 2019 •
edited
Loading

HMI implementation for smartdevicelink/sdl_core#2393.
Get templateTitle parameter from showStrings and display alongside the appName title

@ShobhitAd ShobhitAd force-pushed the feature/template_titles branch from 511b6d5 to 93f065f Compare July 17, 2019 12:19
@ShobhitAd ShobhitAd changed the title Template title parameter Add support for template title parameter Jul 17, 2019
jacobkeeler
jacobkeeler requested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that the template title shouldn't be shown when in the command menu. Perhaps it should just be filled with placeholder text like Menu in this case?

@ShobhitAd ShobhitAd merged commit cd07487 into develop Jul 30, 2019
@Jack-Byrne Jack-Byrne mentioned this pull request Oct 29, 2019
Merged
@jacobkeeler jacobkeeler deleted the feature/template_titles branch July 9, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobkeeler jacobkeeler jacobkeeler approved these changes

Assignees
No one assigned
Labels
proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShobhitAd @jacobkeeler @theresalech