Add image optimizations #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCollin
reviewed
Nov 24, 2020
Co-authored-by: Collin <iCollin@users.noreply.github.com>
iCollin
reviewed
Nov 24, 2020
iCollin
approved these changes
Nov 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293
Adds some optimizations to the image component.
Adds shouldComponentUpdate lifecycle method. This should prevent images from unneccesarily updating when no props have changed. This especially helps with template images since it prevents the canvas from being redrawn unnecessarily.
Storing calculated canvas style properties. This point more-so addresses the issue in Tile images broken on Safari #293. For some unknown reason on Safari 14, the calculated canvas height kept growing causing images to shift downward. The calculated styles for the canvas are now only calculated once and stored.