Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main Menu UI Updates #344

Merged
merged 7 commits into from
Feb 11, 2021
Merged

Main Menu UI Updates #344

merged 7 commits into from
Feb 11, 2021

Conversation

Jack-Byrne
Copy link
Collaborator

@Jack-Byrne Jack-Byrne commented Jan 6, 2021 •
edited
Loading

Fixes #230

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Core Tests

  • AddCommand with all parameters sent to top level menu
  • AddSubmenu with all parameters sent to top level menu
  • AddCommand with all parameters sent to nested sub menu
  • AddSubmenu with all parameters sent to nested sub menu

Core version / branch / commit hash / module tested against: Main Menu UI Updates Branch / 10996ca4d7cee0ff5078412c4b5b35a2f4d7f875 / Ubuntu
Proxy+Test App name / version / branch / commit hash / module tested against: RPC Builder JS / Master / aad0f2f364a7a98cbd4c9ee15fbfbfe4dc28a708

Summary

Adds new text and image parameters to the AddCommand and AddSubmenu RPCs.

CLA

ShobhitAd
ShobhitAd requested changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@ShobhitAd ShobhitAd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new UI params should probably also be implemented in HScrollMenuItem for the TILES MenuLayout.

src/js/VScrollMenuItem.js Outdated Show resolved Hide resolved
src/js/containers/Menu.js Outdated Show resolved Hide resolved
Jack-Byrne and others added 2 commits January 22, 2021 14:47
@Jack-Byrne @ShobhitAd
Apply suggestions from code review
d310be1 
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
@Jack-Byrne
Update text and image capabilities
afe3c5e
@ShobhitAd
Copy link
Contributor

The new UI params should probably also be implemented in HScrollMenuItem for the TILES MenuLayout.

@JackLivio I think this comment still has to be addressed

@Jack-Byrne Jack-Byrne merged commit e5513da into develop Feb 11, 2021
@Jack-Byrne Jack-Byrne deleted the feature/main_menu_ui_updates branch February 11, 2021 22:41
@jacobkeeler jacobkeeler mentioned this pull request May 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShobhitAd ShobhitAd ShobhitAd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jack-Byrne @ShobhitAd