Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/keyboard enhancements #348

Merged
merged 14 commits into from
Feb 12, 2021
Merged

Conversation

Jack-Byrne
Copy link
Collaborator

Fixes #181

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Core Tests

  • Perform interaction keyboard with all layouts (numeric is new layout)
  • Test behavior of masking global property
  • Test behavior of setting custom keys on different layouts

Core version / branch / commit hash / module tested against: Keyboard enhancements branch / 4e7603e604ec578c2aa5fa41784dce6ea5c60fb9
Proxy+Test App name / version / branch / commit hash / module tested against: Test suite master

Summary

Adds support for a new layout: NUMERIC
Adds ability to mask the users input
Adds ability for mobile to set custom keys in place of special characters on the top level of the keyboard layout.

CLA

src/js/Controllers/DisplayCapabilities.js Outdated Show resolved Hide resolved
src/js/Keyboard.js Outdated Show resolved Hide resolved
src/js/Keyboard.js Outdated Show resolved Hide resolved
src/js/Keyboard.js Outdated Show resolved Hide resolved
src/js/Keyboard.js Outdated Show resolved Hide resolved
src/js/Keyboard.js Outdated Show resolved Hide resolved
Jack-Byrne and others added 3 commits January 28, 2021 14:08
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
@jordynmackool jordynmackool self-assigned this Feb 10, 2021
Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it looks like keyboard property changes do not take effect while the keyboard is active unless a button is pressed, which can be a bit jarring. I think that ideally the keyboard should update immediately if the keyboard properties are set while it is active.

src/js/Controllers/DisplayCapabilities.js Outdated Show resolved Hide resolved
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
@Jack-Byrne
Copy link
Collaborator Author

For anyone wondering, we decided that a SetGlobalProperties should not change the keyboard layout while in view.

@jacobkeeler jacobkeeler merged commit dbbeff1 into develop Feb 12, 2021
@jacobkeeler jacobkeeler deleted the feature/keyboard_enhancements branch February 12, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants