-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/keyboard enhancements #348
Conversation
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it looks like keyboard property changes do not take effect while the keyboard is active unless a button is pressed, which can be a bit jarring. I think that ideally the keyboard should update immediately if the keyboard properties are set while it is active.
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
For anyone wondering, we decided that a SetGlobalProperties should not change the keyboard layout while in view. |
…elink/generic_hmi into feature/keyboard_enhancements
Fixes #181
Testing Plan
Core Tests
Core version / branch / commit hash / module tested against: Keyboard enhancements branch / 4e7603e604ec578c2aa5fa41784dce6ea5c60fb9
Proxy+Test App name / version / branch / commit hash / module tested against: Test suite master
Summary
Adds support for a new layout: NUMERIC
Adds ability to mask the users input
Adds ability for mobile to set custom keys in place of special characters on the top level of the keyboard layout.
CLA