Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add video streaming info to readme #371

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Mar 24, 2021

Summary

It was noted that the video streaming setup for the generic HMI was not so clear.

CLA

You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.
Copy link
Collaborator Author

@iCollin iCollin Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i used the github.com markdown editor and it added a newline after this text that i did not notice, the content is unchanged

Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording suggestions

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
@iCollin iCollin merged commit a698fdf into release/0.10.0_RC1 Mar 24, 2021
@iCollin iCollin deleted the fix/video_streaming_in_readme branch March 24, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants