-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reserved keywords #232
Add reserved keywords #232
Conversation
There is a weird case for CancelInteraction where both getFunctionID and setFunctionID are used, but only the getFunctionID is a reserved keyword. If we want consistency with the method name changes, setFunctionID may need to be added to this list so that both will have the same suffix once generated. Thoughts? |
Good point @crokita I am okay with adding |
For clarity, I think that should be
I would add that some reserved keywords have a |
I think this should also be case insensitive |
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
@joeljfischer I applied your requested changes. |
Please resolve my previous question about adding setFunctionID to the list before continuing |
@crokita done. |
Fixes #231
This PR adds a list of keywords that RPC Generators in all platforms (iOS, Java Suite, JavaScript Suite) should avoid using by following these rules:
Param
to it. For examplegetFunctionID
>getFunctionIDParam
#
symbols thenspace
should be considered a comment and ignored (like#<space>
or##<space>
or###<space>
…). Note that some reserved keywords have a#
without a<space>
so it can't just check for#
.