Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.1.0 #315

Merged
merged 25 commits into from
Apr 14, 2021
Merged
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
120d784
Update spec for CustomPlayback Rates Proposal
Nov 18, 2020
4771e9b
Update spec version to 7.1.0
jacobkeeler Dec 3, 2020
6177155
Merge pull request #300 from smartdevicelink/feature/7.1.0_version_bump
jacobkeeler Dec 9, 2020
3e07f96
Interface Parser - Fix getting function param default value (#286)
NicoleYarroch Dec 9, 2020
1905d55
Merge branch 'develop' into feature/SDL_0244_CustomPlaybackRate
Dec 11, 2020
47a51a9
remove xmlschema element getchildren (#308)
iCollin Jan 8, 2021
24eaaec
Merge pull request #294 from smartdevicelink/feature/SDL_0244_CustomP…
Jan 14, 2021
e1ca352
Feature/sdl 0285 ShowConstantTBT update (#304)
Jan 14, 2021
0279ade
Deprecate Show param mediaClock (#309)
ShobhitAd Jan 22, 2021
7ee37e5
Fix RAI appInfo since attribute (#311)
ShobhitAd Jan 22, 2021
7b9d0cd
Deprecate SyncPData Functions (#310)
ShobhitAd Jan 22, 2021
225d7d1
Change formatting for deprecated since note (#312)
ShobhitAd Jan 25, 2021
4e6fc29
Feature/sdl 0255 enhance body information vehicle data (#297)
Jan 25, 2021
adda907
Merge remote-tracking branch 'origin/master' into develop
jacobkeeler Jan 26, 2021
0110478
Update RPC Spec for Media Skip Indicators (#292)
Jan 27, 2021
02109f7
Add changes overwritten by merge commit (#313)
ShobhitAd Jan 28, 2021
b9c2d34
Feature/sdl 0262 new vehicle data seat occupancy (#298)
Feb 2, 2021
390394d
[SDL 0274] add preferred FPS to VideoStreamingCapability (#229)
shiniwat Feb 3, 2021
132dd91
Feature/sdl 0269 new vehicle data climate data (#299)
Feb 9, 2021
f8be1a7
SDL-0305 Homogenize TextFieldName (#303)
JulianKast Feb 9, 2021
d1401e3
Mark params as deprecated (#314)
Feb 11, 2021
07e0f7f
[SDL 0238] Feature Keyboard Enhancements (#306)
ychernysheva Feb 11, 2021
02f592f
Add Main Menu UI Updates from proposal (#293)
Feb 11, 2021
6b98355
[SDL-0296] Possibility to update video streaming capabilities during …
Feb 12, 2021
607dd09
Fix whitespace for 7.1.0 (#317)
Jack-Byrne Apr 13, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions InterfaceParser/parsers/rpc_base.py
Original file line number Diff line number Diff line change
@@ -213,6 +213,18 @@ def _parse_struct(self, element, prefix):
"""
params, subelements, attrib = self._parse_base_item(element, prefix)

# Create an empty object for new type to types collection.
# This is needed for parser to apply type for struct members
# that consist of its own type.
# E.g.:
# struct VideoStreamingCapability {
# ...
# VideoStreamingCapability additionalVideoStreamingCapabilities[]
# }

struct = Struct(**params)
self._add_type(struct)

for attribute in attrib:
if attribute in ["scope", "deprecated", "removed"]:
params[attribute] = attrib[attribute]
@@ -229,6 +241,12 @@ def _parse_struct(self, element, prefix):
raise ParseError("Unexpected subelement '{}' in struct '{}'".format(subelement.name, params["name"]))
params["members"] = members

# Remove empty object for new type to prevent errors of adding such type twice (see self._add_type).
# After return statement of current method is done the new type with all its params
# will be added into types collection.

self._types.pop(struct.name, None)

return Struct(**params)

def _parse_function(self, element, prefix):
@@ -443,7 +461,16 @@ def _parse_function_param(self, element, prefix):
params, subelements, attrib = self._parse_param_base_item(element, prefix)

default_value = None
default_value_string = self._extract_attrib(attrib, "defvalue")
default_value_string = None

default_value_param_key = "default_value"
if default_value_param_key in params:
default_value_param = params[default_value_param_key]
if isinstance(default_value_param, EnumElement):
default_value_string = default_value_param.name
else:
default_value_string = str(default_value_param)

if default_value_string is not None:
param_type = params["param_type"]
if isinstance(param_type, Boolean):
@@ -617,7 +644,7 @@ def _parse_base_enum_element(subelement, base_type, params):
if len(subelement.attrib) != 1:
raise ParseError("Unexpected attributes for element '{}' of parameter '{}'"
.format(element_name, params["name"]))
children = subelement.getchildren()
children = list(subelement)
for child in children:
if child.tag == "description":
children.remove(child)
@@ -690,10 +717,9 @@ def _get_bool_from_string(bool_string):
:param bool_string: string with attribute value
:return: converted value.
"""

if bool_string in ['0', 'false']:
if bool_string.lower() in ['0', 'false']:
value = False
elif bool_string in ['1', 'true']:
elif bool_string.lower() in ['1', 'true']:
value = True
else:
raise ParseError("Invalid value for bool: '{}'".format(bool_string))
Loading