Script for reproducing issue 1409 #1981
Conversation
HSavynetska
force-pushed
the
Defect_1409
branch
from
e93015a to
43ca852
Compare
| -- Precondition: | ||
| -- 1) SDL and HMI are started | ||
| -- 2) SPT is registered using v3 protocol and activated on HMI | ||
| -- Description: |
There was a problem hiding this comment.
Please move Description before Precondition and fill out it.
| -- Steps to reproduce: | ||
| -- 1) Start Video Service -> SDL send StartServiceACK to mobile | ||
| -- 2) Start Audio service -> SDL send StartServiceACK to mobile | ||
| -- 3) Send IGNITION_OFF from HMI: On HTML5 HMI click Exit Application and select Ignition Off from drop down |
There was a problem hiding this comment.
Why here we need information about HTML5 HMI?
|
|
||
| config.defaultProtocolVersion = 3 | ||
|
|
||
| --[[ Local Variables ]] |
There was a problem hiding this comment.
Please remover redundant block name.
| end | ||
|
|
||
| local function ExitAllApplications(self) | ||
| StopSDL() |
There was a problem hiding this comment.
Why SDL stops before processing all messages?
| StopSDL() | ||
| self.hmiConnection:SendNotification("BasicCommunication.OnExitAllApplications", { reason = "IGNITION_OFF" }) | ||
| local event = events.Event() | ||
| event.matches = function(_, data) |
There was a problem hiding this comment.
Please perform alignment
| :Times(3) | ||
| :ValidIf(function(_, data) | ||
| if data.frameInfo == 4 and data.serviceType == 11 then | ||
| self.mobileSession1:Send( |
There was a problem hiding this comment.
EndServiceACK sgould be sent for all services not only for 11
| :Timeout(60000) | ||
| :Times(3) | ||
| :ValidIf(function(_, data) | ||
| if data.frameInfo == 4 and data.serviceType == 11 then |
There was a problem hiding this comment.
for loop for all EndServiceACK's can be updated to
if data.frameInfo == 4 and data.serviceType == 11 or data.serviceType == 10 or data.serviceType == 7 then
.....
return true
end
return false, "End Service not received"
| runner.Title("Test") | ||
| runner.Step("App starts Audio streaming", appStartAudioStreaming) | ||
| runner.Step("App starts Video streaming", appStartVideoStreaming) | ||
| runner.Step("Exit application", ExitAllApplications) |
There was a problem hiding this comment.
Better update to Ignition off
| (data.frameInfo == 4) --EndService | ||
| end | ||
| self.mobileSession1:ExpectEvent(event, "EndService") | ||
| :Timeout(60000) |
There was a problem hiding this comment.
Why this timer is 60 seconds? can it be reduced?
| @@ -0,0 +1,107 @@ | |||
| -- User story: https://github.com/SmartDeviceLink/sdl_core/issues/1409 | |||
There was a problem hiding this comment.
Please add test set in ./test_sets/Defects/6_1 folder
GetmanetsIrina
force-pushed
the
Defect_1409
branch
from
43ca852 to
22fa491
Compare
There was a problem hiding this comment.
@GetmanetsIrina Please update description of PR according to template
|
The PR has been rebased on the current develop branch (ebab459). The script has been ran on the next flows and transport types: PROPRIETARY: TCP - PASSED, WS - PASSED, WSS - PASSED |
|
PR is actual |
|
@jordynmackool, PR is ready for Livio review. |
ATF Test Scripts to check #1409
This PR is ready for review.
Summary
Check the receiving of EndService messages for video and audio, RPC services during ignition off.
ATF version
develop
CLA