Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/SDL passenger mode #2160

Merged
merged 12 commits into from
Jul 24, 2019
Merged

Feature/SDL passenger mode #2160

merged 12 commits into from
Jul 24, 2019

Conversation

HSavynetska
Copy link
Contributor

ATF Test Scripts to check #2134

This PR is ready for review.

Summary

Scripts for "SDL Passenger Mode" feature

ATF version

develop

CLA

@dboltovskyi dboltovskyi force-pushed the feature/sdl_passenger_mode branch 3 times, most recently from 684039e to f6589a4 Compare December 18, 2018 08:19
@IGapchuk IGapchuk force-pushed the feature/sdl_passenger_mode branch from f6589a4 to 3f6c56b Compare May 22, 2019 18:12
@IGapchuk IGapchuk mentioned this pull request May 22, 2019
Merged
1 task
@IGapchuk IGapchuk changed the title Initial scripts for SDL Passenger Mode feature [SDL 0119] SDL Passenger Mode May 23, 2019
@IGapchuk IGapchuk changed the title [SDL 0119] SDL Passenger Mode Feature/SDL passenger mode May 23, 2019
yang1070
yang1070 approved these changes May 29, 2019
View reviewed changes
Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ford has reviewed and approved this PR.

@HSavynetska HSavynetska force-pushed the feature/sdl_passenger_mode branch from 3f6c56b to f4d2de1 Compare June 6, 2019 09:49
@GetmanetsIrina GetmanetsIrina force-pushed the feature/sdl_passenger_mode branch from f4d2de1 to 4baee3c Compare June 6, 2019 10:09
@GetmanetsIrina
Copy link
Contributor

@jacobkeeler, the update according to review comments is performed, please review in 4baee3c

@jacobkeeler
Copy link
Contributor

Another note, it seems that the smoke tests fail on smartdevicelink/sdl_core#2783 with:

[11:25:25,223] RAI                                                                                   [FAIL] (10871 ms)
 OnDriverDistraction notification: Timeout: OnDriverDistraction notification: Timeout expired

I don't know whether this is a script or Core issue.

@dboltovskyi
Copy link
Contributor

@jacobkeeler We're unable to reproduce this issue on our environment.
Is it reproduced with every test scripts from PR or just with a single one?
Is it reproduced randomly?
Could you provide SDL and ATF logs please?
One of the reason could be not correct sdl_preloaded_pt.json file which is updated during script execution.
Could you restore it from initial SDL build and re-run the tests?

@jacobkeeler
Copy link
Contributor

@dboltovskyi Don't know what the cause of this was, but a clean rebuild did appear to fix the issue. Approving.

@IGapchuk
Copy link
Contributor

@jacobkeeler @JackLivio Please, be informed that we've added new commits that cover implementation for next revisions of the proposal: smartdevicelink/sdl_evolution#766 and smartdevicelink/sdl_evolution#775. Please take a look at next commits: d355522, a2052be, 2c2c742, aa08783, a5c5f0d, 1229a97

@mrapitis
Copy link

@theresalech Ford has reviewed and approved this PR.

@jacobkeeler jacobkeeler merged commit 3a0313b into develop Jul 24, 2019
@jacobkeeler jacobkeeler deleted the feature/sdl_passenger_mode branch February 2, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dboltovskyi dboltovskyi dboltovskyi left review comments

@jacobkeeler jacobkeeler jacobkeeler approved these changes

@yang1070 yang1070 yang1070 approved these changes

@Jack-Byrne Jack-Byrne Awaiting requested review from Jack-Byrne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HSavynetska @GetmanetsIrina @jacobkeeler @dboltovskyi @IGapchuk @mrapitis @yang1070