Add filtering moduleIds for GetInteriorVehicleDataConsent requests to the HMI #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ATF Test Scripts for modified behavior in core fix #3050
This PR is ready for review.
Summary
Core fix #3050 adds behavior to filter the moduleIds in the
GetInteriorVehicleDataConsentrequest forwarded to the HMI for consent.Currently if an app sends
GetInteriorVehicleDataConsentwith two moduleIds(one free and one taken by another user) core would ask the HMI for consent for both moduleIds, even though one of the modules is free.After this core fix, the moduleIds sent to the HMI will be filtered based on whether or not core can automatically decide what the consent should be for a particular moduleId. (For example in the test case https://github.com/smartdevicelink/sdl_atf_test_scripts/blob/develop/test_scripts/RC/MultipleModules/ModulesAllocation/059_3_GetInteriorVehicleDataConsent_ASK_DRIVER_multiple_modules_part_free.lua)
ATF version
develop
CLA