Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update 090 to new common files #2479

Merged
merged 4 commits into from
Nov 20, 2020
Merged

update 090 to new common files #2479

merged 4 commits into from
Nov 20, 2020

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Nov 16, 2020

This PR is ready for review.

Summary

this test was a non-actual failure. i've updated it to use the new common files so this test will be valid.

ATF version

latest

CLA

@iCollin
Copy link
Collaborator Author

iCollin commented Nov 18, 2020

Great catch on isSelfIncluded, all comments were adressed in 669c868

@dboltovskyi
Copy link
Contributor

dboltovskyi commented Nov 19, 2020 •
edited
Loading

@iCollin Please consider 2 items from my side:

  1. In order to support (and restrict) more connection types and SDL configurations I would suggest to make updates similar to the ones described in Additional updates for 215 policy script #2485
  2. Add script into policy test set: policies_happy_paths_EXTERNAL_PROPRIETARY.txt and enable it in policies_all_flows.txt

@iCollin iCollin merged commit 2bd5874 into develop Nov 20, 2020
@iCollin iCollin deleted the fix/090_ptu_consented_only branch November 20, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobkeeler jacobkeeler jacobkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iCollin @dboltovskyi @jacobkeeler