Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query type from SendHandshakeData event matcher #2574

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

jacobkeeler
Copy link
Contributor

ATF Test Scripts to check smartdevicelink/sdl_core#3755

This PR is ready for review.

Summary

Remove query type from event matcher for SendHandshakeData, use RESPONSE type in SendHandshakeData response.

ATF version

smartdevicelink/sdl_atf#237

Changelog

Bug Fixes
  • Remove query type from event matcher for SendHandshakeData
  • Use RESPONSE type in SendHandshakeData response instead of NOTIFICATION

CLA

Also change response to proper query type
@jacobkeeler jacobkeeler merged commit 4c9ae5a into develop Aug 27, 2021
@jacobkeeler jacobkeeler deleted the fix/send_handshake_data_query_type branch August 27, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants