Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerformInteraction: SDL doesn't ignore ABORTED result code from VR.PerformInteraction in case of BOTH mode #1583

Closed
5 of 9 tasks
DrachenkoAnastasiia opened this issue Jun 1, 2017 · 1 comment
Labels

Comments

@DrachenkoAnastasiia
Copy link

Occurrence

Always

Preconditions

  1. SDL is built with Proprietary flag.
  2. SDL and HMI are started. First ignition cycle.
  3. Connect device
  4. Register new application.
  5. Put icon.png file using PutFile RPC
  6. Create a сhoiceSet with VR choices:interactionChoiceSetID1

Steps to reproduce

  1. PerfromInteraction with previously created choiceSet:
    app -> SDL:PerfromInteracton(interactionChoiceSetID1, interactionMode = "BOTH")
  2. SDL sends the both: VR and UI portion
    SDL->HMI: VR.PerformInteraction()
    SDL->HMI: UI.PerfrormInteraction()
  3. Make the following choices:
    HMI->SDL: VR.PerformInteraction(): SendError("ABORTED")
    HMI->SDL: UI.PerformInteraction(): SendResponse("UNSUPPORTED_RESOURCE")
  4. SDL->App: PerfromInteracton response --> check parameters

Actual result

{ success = false, resultCode = "ABORTED" }

Expected result

{ success = true, resultCode = "UNSUPPORTED_RESOURCE"}

Environment

SDL: https://github.com/LuxoftAKutsan/sdl_core/tree/integration/4.3.1 (35344c8)
ATF: https://github.com/smartdevicelink/sdl_atf/tree/develop (fe002fb)
ATF Scripts: https://github.com/smartdevicelink/sdl_atf_test_scripts/tree/develop (4ba374c)
OS: Ubuntu 14.04 LTS x64

Attachments

SDLOPEN-2443.zip

Expected delivery

  • Source code updates
  • Code comments
  • UTs add/update
  • ATF tests add/update (not required)
  • Manual tests (not required)
  • Add/update CI plans/jobs (not required)
  • SDD updates (not required)
  • Guidelines update (sdl_core_guides) (not required)
  • Guidelines update (sdl_hmi_integration_guidelines) (not required)
@jacobkeeler
Copy link
Contributor

Closing with the merge of #3587

@Jack-Byrne Jack-Byrne mentioned this issue Mar 18, 2021
1 task
@jacobkeeler jacobkeeler changed the title PerformInteraction: SDL doesn't ignore ABORTED result code from VR.PerformIntercation in case of BOTH mode PerformInteraction: SDL doesn't ignore ABORTED result code from VR.PerformInteraction in case of BOTH mode Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants