Release 7.1.0 #3669
Merged
Release 7.1.0 #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation SDL starts session heartbeat right after application registration. However the correct behavior is to start session heartbeat after first heartbeat request from mobile app. Following changes were done: - Removed starting session heartbeat on app registration - Added session heartbeat start on frist heartbeat request from mobile app - Added check to prevent starting of session heartbeat if it was disabled in settings
This prevents SDL from starting HB session tracking every time SDL receives HB request from mobile.
…artbeat_starting # Conflicts: # src/components/connection_handler/include/connection_handler/heartbeat_monitor.h # src/components/connection_handler/src/connection.cc # src/components/connection_handler/src/heartbeat_monitor.cc # src/components/protocol_handler/src/protocol_handler_impl.cc
* Cover connection handler and policy handler with unit tests Few tests added to connection_handler_impl_test.cc and to connection_test.cc There were 2 mocks for telemetry observer. So, one is removed (src/components/include/test/protocol_handler/mock_telemetry_observer.h) Fixed mock_telemetry_observer.h (src/components/protocol_handler/ test/include/protocol_handler/mock_telemetry_observer.h) Added tests to protocol_handler_tm_test.cc set_hash_id and get_hash_id are covered with unit tests. set_hash_id, get_hash_id, ConvertPacketDataToString, get_protocol_observers_count declarations are added to protocol_handler_impl.h under BUILD_TEST flag. Resolves: #2449 * fix according to comments * Unit test for get_hash_id and set_hash_id Removed declarations for internal functions get_hash_id and set_hash_id ConvertPacketDataToString moved to convert_utils as ConvertBinaryDataToString Fixed unit tests for get_hash_id and set_hash_id * replace dcheck or return to if in ConvertBinaryDataToString due to issue in smoke tests * minor UT fixes * Update doxygen for convert_utils * Address comments and fix UT Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
…at_starting Fix session heartbeat starting
* Fix policy validation of OnVehicleData message * Fix unit tests Co-authored-by: Mykola Korniichuk <mkorniichuk@luxoft.com>
consumer_friendly_messages.messages was being omitted from the policy table json rather than just the snapshot, this reintroduces this field (this field is still cleared out when generating the snapshot in `CheckSnapshotInitialization`)
…dly_messages Re-add messages field in policy table json
* Add OnWayPointChange handling for NAVIGATION app services * Only send OnWayPointChange to mobile from active waypoints provider
…_omitted Handle omitted parameter permissions properly in OnVehicleData notification
…on_at_registration Bind protocol version when app registers
…it_tests Fix failing unit tests in hmi_notifications_test
…fields Check for revoked apps when reading mandatory policy fields
…icies Fix variable usage in OnVehicleDataNotification
* Fix build failure with ENABLE_LOG=OFF Also fix unused variable warnings caused by the same configuration
…Cs (#3587) * Fix success=false after UNSUPPORTED_RESOURCE response for multiple RPCs Fixes issue for PerformInteraction, Alert, SubtleAlert, AlertManeuver, and PerformAudioPassThru
* Fix applying heart_beat_timeout_ms from PreDataConsent After sending SDL.OnAllowSDLFunctionality(allowed = false) application is assigned to PreDataConsent group. After this HB timeout is set to timeout from PreDataConsent * Updated logs messages and simplify vars after review * Update unit tests * Fix syntax errors after rebase * fixup! Fix syntax errors after rebase Co-authored-by: Veronica Veremjova <vveremjova@luxoft.com> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* initialize AppPermissions.isSDLAllowed in constructor * Update src/components/policy/policy_external/include/policy/policy_types.h Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> * apply to regular policies Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
Also apply style fixes
Removed msg_params section forwarding for case when response was not successful.
* Fix setting encrypted block size when cipher is unknown * Add missing cipher to list
* Update boost installation to 1.72.0 * Fix boost installation process Properly set boost directories when the library is found, also run clean step before installation to prevent lingering old versions of boost
* Update boost installation to 1.72.0 * Fix boost installation process Properly set boost directories when the library is found, also run clean step before installation to prevent lingering old versions of boost * Fix websocket implementation * Update Configurations for openssl 1.1.1 * Update src/components/security_manager/src/crypto_manager_impl.cc Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com> Co-authored-by: jacobkeeler <jacob.keeler@livioradio.com>
* Compile ssl version check * Fix comparison * Remove redundant tls 1.3 check
Co-authored-by: collin <collin+i@collinmcqueen.com>
…est with invalid data (#3647) * Fix NACK sending for Start RPC service with invalid data in bson payload. Fix memory leak with session after Start RPC service NACK. Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode. Fix NACK sending for Start any service with non-existent session id. * fixup! Fix NACK sending for Start RPC service with invalid data in bson payload. Fix memory leak with session after Start RPC service NACK. Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode. Fix NACK sending for Start any service with non-existent session id. * fixup! fixup! Fix NACK sending for Start RPC service with invalid data in bson payload. Fix memory leak with session after Start RPC service NACK. Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode. Fix NACK sending for Start any service with non-existent session id. Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* Configure security level in ini file Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* Add status check for bt scan * Create separate thread to handle the paired device and hci inquiries * Style fix * Initialize inquiry thread in constructor and add thread start check * Remove scan for unpaired devices * Remove inquiry thread * Add timeout, remove found_devices_with_sdl_, fix conflicts * Prevent automatic cloud connections * Fix bluetooth thread issues * Fix style * Remove new lines * Fix threading issues * Prevent deadlock on shutdown * Rename CV Lock * Style Co-authored-by: JackLivio <jack@livio.io>
* Check waypoint subscription size in resumption * Update modifiers
This was referenced Apr 13, 2021
jacobkeeler
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review. Reported issues and pull requests will be prioritized for development and review.
Risk
This PR makes minor API changes.
Features
[SDL 0238] Keyboard Enhancements
[SDL 0267] Main Menu UI Updates
[SDL 0296] Possibility to update video streaming capabilities during ignition cycle
[SDL 0274] Add preferred FPS to VideoStreamingCapability
[SDL 0269] New vehicle data ClimateData
[SDL 0244] Custom Playback Rates for SetMediaClockTimer
[SDL 0262] New vehicle data SeatOccupancy
[SDL 0285] ShowConstantTBT Description Update
[SDL 0255] Enhance BodyInformation vehicle data
[SDL 0198] Media Skip Indicators
[SDL 0328] Add Ubuntu 20.04 support - Partial implementation of proposal. Ubuntu 20 is supported in this release, but dropping support for Ubuntu 16 requires a major version change. This release supports Ubuntu 16, 18, and 20.
[SDL 0305] Homogenize TextFieldName
[SDL 0180] Broaden Choice Uniqueness
[SDL 0293] Enable OEM exclusive apps support
Bug Fixes
Bluetooth device scan preventing update app list
SDL sends GetInteriorVehicleData response with moduleData = null in case of erroneous response type for GetInteriorVehicleData from HMI
TTS.Speak: appID parameter is not provided
NONEHMI level is missed for RPCs in "WidgetSupport" policy groupSDL does not send revert RC.SetGlobalProperties requests to HMI during revert of resumption in case of erroneous response type
Cmake 3.10 Boost error
SDL encrypts payload of 1st frame of multi-frame message
Startup PTU triggers are not checked for HMI PTU in EXTERNAL_PROPRIETARY mode
ResumeController considers WARNINGS with message as reason to fail resumption
Unable to build SDL with -DCMAKE_BUILD_TYPE=Release on Ubuntu 20.04
SDL doesn't wait for IsReady responses from HMI to send Ack or RAI response
SDL resumes App's defined keyboard properties if they have been reset
Add default value for maskInputCharacters to ResetGlobalProperties
SDL is unable to stream different audio files
Update some scripts to python3
SDL sometimes sends 2 requests to HMI with the same id
Fix protocol handler unit test crash
SDL doesn't send RC.SetGlobalProperties during resumption
Rare crash during UnsubscribeVehicleData
FAIL occurs in ApplicationHelperTest when unit test is performed with SDL Core 7.0.0
For some RPCs, Core does not unsubscribe from softbuttons after receiving a response
Build failure with -DBUILD_TESTS=ON -DENABLE_SECURITY=OFF
CCB : protocol handler unit test stuck
CCB: Fixed Issue related to SetAppIcon Path
CCB: Fix for a potential SDL crash on boot
SSL Context should use MACRO instead of direct struct access
Revoked app can be activated via device consent in EXTERNAL_PROPRIETARY
PerformInteraction: SDL doesn't ignore ABORTED result code from VR.PerformInteraction in case of BOTH mode
Alert, AlertManeuver, PerformAudioPassThru: SDL sends success = false in case of UNSUPPORTED_RESOURCE
PerformInteraction: SDL sends success = false in case of UNSUPPORTED_RESOURCE
Resumption doesn't work in the next ignition cycle after unexpected disconnect for 2nd app
SDL build fails with ENABLE_LOG=OFF
Close namespace
SDL doesn't apply heart_beat_timeout_ms received after PTU
Revoked app does not receive OnHMIStatus upon registration in EXTERNAL_PROPRIETARY
SDL allows starting Video service for 2nd version of SDL protocol
SDL doesn't allow VD parameters if parameters section is omited in policies for OnVehicleData
SDL Core ignores OnWayPointChange from NAVIGATION App Service Provider
Core sends binary data only for PROPRIETARY requestType
SDL transfers OnVehicleData to mobile app if VD param does not exist in app's assigned policies
SDL must start heartbeat only after first Heartbeat request from mobile app
CLA