Handle omitted parameter permissions properly in OnVehicleData notification

[jacobkeeler]

Fixes #3577

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Run ATF tests listed in #3577 (comment)

Summary

Allow all parameters in OnVehicleData if parameters field is omitted

Changelog

Bug Fixes

• Allow all parameters in OnVehicleData if parameters field is omitted

CLA

• I have signed the CLA

[iCollin]

please run style script also

120,121c120
<     }
<     else {
---
>     } else {
in  src/components/application_manager/rpc_plugins/vehicle_info_plugin/src/commands/mobile/on_vehicle_data_notification.cc

[iCollin]

if i set these all to empty arrays, all params should be allowed, correct?

is there any way to differentiate between the case of all being defined as [] and the whole object missing?

[jacobkeeler]

This is the way that it is checked in CommandImpl::CheckAllowedParameters, I believe that all of the provided parameters would be in the disallowed_params list in the case that it is defined as [], so these lists would not be empty.

[dboltovskyi]

@jacobkeeler Please notice the following scripts start failing within this fix:

./test_scripts/API/VehicleData/OnVehicleData/002_OnVD_disallowed.lua
./test_scripts/API/VehicleData/OnVehicleData/003_OnVD_disallowed_after_PTU.lua

SDL Core: https://github.com/smartdevicelink/sdl_core/tree/develop (2e5c3ab)
ATF Report and Logs:

• 2020-12-14_11-03-44.594.tar.gz
• 2020-12-14_11-19-16.883.tar.gz