Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL doesn't allow VD parameters if parameters section is omitted in policies for OnVehicleData #3577

Closed
dboltovskyi opened this issue Nov 17, 2020 · 3 comments
Labels

Comments

@dboltovskyi
Copy link
Contributor

dboltovskyi commented Nov 17, 2020

Bug Report

SDL doesn't allow VD parameters if parameters section is omited in policies for OnVehicleData

In general there are 3 options related to parameters for RPC in policies:

  1. parameters section is omitted - allow all parameters
  2. parameters section contains empty array (e.g. []) - disallow all parameters
  3. parameters section contains some parameters (e.g. ["speed, "gps"]) - allow only defined parameters
Reproduction Steps
  1. Make sure there is a functional group in policies with OnVehicleData but with omitted parameters section
  2. Register app
  3. Subscribe for some Vehicle Data
  4. Send VI.OnVehicleData from HMI with any VD parameter
Expected Behavior

SDL allows transferring OnVehicleData to App

Observed Behavior

SDL doesn't allow transferring OnVehicleData to App

OS & Version Information
Test Case, Sample Code, and / or Example App
@dboltovskyi
Copy link
Contributor Author

Issue is not reproduced at 7.0.0 and seems introduced by #3568

@dboltovskyi
Copy link
Contributor Author

Scripts affected:

./test_scripts/TheSameApp/Subscriptions/006_Two_apps_with_same_appName_DIFF_devices_send_subscribe_on_VehicleData.lua
./test_scripts/TheSameApp/Subscriptions/007_Two_apps_with_same_appName_DIFF_devices_send_subscribe_unsubscribe_on_VehicleData.lua
./test_scripts/Resumption/Handling_errors_from_HMI/001_successful_resumption_SUCCESS_resultCode.lua
./test_scripts/Resumption/Handling_errors_from_HMI/002_successful_resumption_other_successful_result_codes.lua
./test_scripts/Resumption/Handling_errors_from_HMI/005_resume_all_data_with_one_error_rpc_unexpected_disconnect.lua
./test_scripts/Resumption/Handling_errors_from_HMI/006_resume_all_data_with_one_error_rpc_ign_off.lua
./test_scripts/Resumption/Handling_errors_from_HMI/009_restore_subscription_for_app2_after_fail_for_app1.lua
./test_scripts/Resumption/Handling_errors_from_HMI/010_restore_subscription_for_app2_after_fail_in_sub_resultCode_for_app1.lua
./test_scripts/Resumption/Handling_errors_from_HMI/011_unsubscribe_from_the_same_vehicledata_without_request_to_hmi_by_error_during_resumption.lua
./test_scripts/Resumption/Handling_errors_from_HMI/012_unsubscribe_from_the_same_vehicledata_without_request_to_hmi_by_error_in_sub_resultCode_during_resumption.lua
./test_scripts/Resumption/Handling_errors_from_HMI/032_Same_RPC_VD_RAI2_before_request_to_HMI.lua
./test_scripts/Resumption/Handling_errors_from_HMI/033_Same_RPC_VD_RAI2_before_erroneous_response_from_HMI.lua
./test_scripts/Resumption/Handling_errors_from_HMI/034_Same_RPC_VD_RAI2_after_erroneous_response_from_HMI.lua
./test_scripts/Resumption/Handling_errors_from_HMI/038_Another_RPC_VD_RAI2_before_request_to_HMI.lua
./test_scripts/Resumption/Handling_errors_from_HMI/039_Another_RPC_VD_RAI2_before_erroneous_response_from_HMI.lua
./test_scripts/Resumption/Handling_errors_from_HMI/040_Another_RPC_VD_RAI2_after_erroneous_response_from_HMI.lua
./test_scripts/Resumption/Handling_errors_from_HMI/044_Another_RPC_VD_delayed_response_from_HMI.lua

@jacobkeeler
Copy link
Contributor

Closing with the merge of #3590

@Jack-Byrne Jack-Byrne mentioned this issue Mar 18, 2021
1 task
@jacobkeeler jacobkeeler changed the title SDL doesn't allow VD parameters if parameters section is omited in policies for OnVehicleData SDL doesn't allow VD parameters if parameters section is omitted in policies for OnVehicleData Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants