Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure with ENABLE_LOG=OFF #3604

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Conversation

jacobkeeler
Copy link
Contributor

Fixes #3588

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Build with ENABLE_LOG=OFF

Summary

Fix build failure and unused variable warning with ENABLE_LOG=OFF

Changelog

Bug Fixes
  • Fix build failure and unused variable warning with ENABLE_LOG=OFF

CLA

Also fix unused variable warning caused by the same configuration
@ShobhitAd
Copy link
Contributor

I am seeing two other unused variable warnings when building with ENABLE_LOG=OFF.

../sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/waypoints_pending_resumption_handler.cc: In member function ‘virtual void sdl_rpc_plugin::WayPointsPendingResumptionHandler::on_event(const application_manager::event_engine::Event&)’:
../sdl_core/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/waypoints_pending_resumption_handler.cc:157:18: warning: unused variable ‘corr_id’ [-Wunused-variable]
   const uint32_t corr_id = event.smart_object_correlation_id();
../sdl_core/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_app_extension.cc: In member function ‘virtual void rc_rpc_plugin::RCAppExtension::RevertResumption(const ns_smart_device_link::ns_smart_objects::SmartObject&)’:
../sdl_core/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_app_extension.cc:201:14: warning: unused variable ‘module’ [-Wunused-variable]
   for (auto& module : module_subscriptions) {

@jacobkeeler jacobkeeler merged commit 49bf5df into develop Dec 17, 2020
@jacobkeeler jacobkeeler deleted the fix/enable_log_off_build branch December 17, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants