Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The OnEventChanged notification provides the wrong state info during app activation #1608

Closed
mrapitis opened this issue Jun 13, 2017 · 3 comments

Comments

@mrapitis
Copy link
Contributor

Description:
When an app is activated, the onEventChanged notification erroneously does not distinguish between different App types (Media, Non-Media, Navigation) -- this eventually leads to wrong onHMIStatus notifications sent to the mobile app.

Occurrence:
Always

Use Cases:
Example use cases where sdl core is processing the OnEventChanged notification incorrectly:

  • A navigation app type is activated during an active embedded audio source or embedded navigation session
  • A media app is activated during an active embedded audio source or embedded navigation session
  • Navigation and media app perform audio streaming during active embedded audio and navigation source selection
  • A non-media app is activated during active embedded audio source or navigation selection
  • Multiple app activated during active embedded navigation or audio source selection

Reproduction Steps and Observed Behavior:
Ensure a navigation app type is running and has a FULL and AUDIBLE state
Activate an embedded audio source
Take note of the following messaging

  • HMI -> SDL: OnEventChanged (AUDIO_SOURCE, isActive=true)
  • SDL -> NAVI app: OnHMIStatus (LIMITED, NOT_AUDIBLE)

Activate a navigation type app
Take note of the following messaging

  • HMI -> SDL: SDL.ActivateApp ()
  • SDL -> HMI: SDL.ActivateApp (SUCCESS)
  • HMI -> SDL: OnEventChanged (AUDIO_SOURCE, isActive=false)
  • SDL -> NAVI app:OnHMIStatus (FULL, AUDIBLE)

Expected Behavior:
Ensure a navigation app type is running and has FULL and AUDIBLE state
Activate an embedded audio source
Please take note of the changes in messaging below:

  • HMI -> SDL: OnEventChanged (AUDIO_SOURCE, isActive=true)
  • SDL -> NAVI app: OnHMIStatus (LIMITED, AUDIBLE)

Activate a navigation type app
Take note of the following messaging

  • HMI -> SDL: SDL.ActivateApp ()
  • SDL -> HMI: SDL.ActivateApp (SUCCESS)
  • SDL -> NAVI app:OnHMIStatus (FULL, AUDIBLE)
@theresalech
Copy link
Contributor

In June 27 SDLC Steering Committee Meeting, Steering Committee agreed that this should be high priority.

@dboltovskyi
Copy link
Contributor

Issue is very similar to #1906

@jacobkeeler
Copy link
Contributor

Closing with the merge of #3476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants