Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0.0 Release #3551

Merged
merged 183 commits into from
Nov 5, 2020
Merged

7.0.0 Release #3551

merged 183 commits into from
Nov 5, 2020

Conversation

Jack-Byrne
Copy link
Collaborator

Completed Features

Completed Bug Fixes/Enhancements

jacobkeeler and others added 30 commits August 29, 2018 17:16
@jacobkeeler
Fix Start Stream retry count
e85b2af
@Jack-Byrne
Merge remote-tracking branch 'origin/master' into develop
5a98aa9
@iCollin @jacobkeeler
Update HMI_API.xml (#3354)
5dc4233 
* Update HMI_API.xml

* Update src/components/interfaces/HMI_API.xml

Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>

Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
@mkorniichuk @jacobkeeler
SDL crash during cleanup. (#2621)
4f82834 
* SDL crash during StopComponents() if StartComponents() failed.

If resumption_storage_ in ResumeCtrlImpl is failed to initialize,
SDL will try to stop components and exit with error code.
At this time application manager tries to unregister all applications and
call ResumeCtrlImpl::OnIgnitionOff() where resumption_storage_ is used. As a result, a crash will occur.

As an example, if AppStorageFolder have no read/write access, resumption_storage_
fails to initialize.

Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
@ONyzhnyk-Luxoft
Fixing problem with validation of array (#2669)
9cc81b7 
* Fixing problem with validation of array
@SKobziev
Add missing ssl_context.h include in security_manager_listener (#2775)
9f7ab68
@iCollin
[SDL4.0]SDL does not create icons folder in case it was removed (#2649)…
902144c 
… (#3359)

The check for existence directory of app icons folder
has been added to SetAppIconRequest.

Co-authored-by: ValeriiMalkov <vmalkov@luxoft.com>

Co-authored-by: ValeriiMalkov <vmalkov@luxoft.com>
@iCollin
Fix Compile Warnings (#3356)
bfacfcb 
* fix warning:maybe-uninitialized in CStringToEnum

* fix out of buffer write warning in unit tests

* Apply suggestions from code review
@iCollin
RAI reply DUPLICATE_NAME when app has same id and name as existing app
236bdba
@iCollin
Revert "RAI reply DUPLICATE_NAME when app has same id and name as exi…
8139bd6 
…sting app"

This reverts commit 236bdba.
@iCollin
only return if we are sure we are out of space (#3361)
401cd47
@iCollin
ResetGlobalProperties doesn't reset HELPPROMPT and VRHELPITEMS to def…
63e8380 
…ault values (#3357)

* Fix bug `ResetGlobalProperties` (#2337)

Fix bug `ResetGlobalProperties` does't reset `HELPPROMPT`
and `VRHELPITEMS` to default values

Fix UT's after bugfixing

 - Fix `ResetGlobalPropertiesRequestTest`
 - Add mock function into `MockApplicationManagerSettings`

Github issue #1306

Co-authored-by: v-malko4 <vmalkov@luxoft.com>

* fix vr_help_title SO type, rename help_prompt_ in unit tests to so_help_prompt

* fix style

Co-authored-by: v-malko4 <vmalkov@luxoft.com>
@jacobkeeler
Merge pull request #2553 from smartdevicelink/fix/start_stream_retry_…
86f87ca 
…count

Fix Start Stream retry count
@ShobhitAd
Fix/Add Startup PTU trigger check (#3363)
b982ad2 
* Add Startup PTU check

* Reset Stop PTU etry when first app is registered

* Address review comment
@iCollin @fronneburg
Fix/issue 1951 (#3371)
a42a370 
* remove deadlock danger when removing Connections from a ConnectionMap

* fix style, use log debug instead of trace for singular messages

* Revert "fix style, use log debug instead of trace for singular messages"

This reverts commit c83288e.

* fix style, use log debug instead of trace for singular messages

* restore condition updates lost with merge of old versions

Co-authored-by: Frank <fronneburg@xevo.com>
@ychernysheva
Change reason to IGNITION_OFF only if reason wasn't defined before (#…
c5620e1 
…3274)
@ychernysheva @Jack-Byrne
Add RPCService unit tests (#3250)
99e8ddc 
* Add RPCService unit tests

* Add prerequisites for execution of unit tests

* Rearrange and delete unused includes

* Add minor changes

Co-authored-by: JackLivio <jack@livio.io>
@KVGrygoriev @iCollin
Fix SendUpdateAppList and SendOnAppUnreg order (#2517)
bb4a6fb 
Co-authored-by: collin <collin@livio.io>
@ZhdanovP
Release delegate only after full thread stopping (#2534)
d97eba8
@iCollin
fix memory error in TcpDevice::IsSameAs (#3386)
42d6654
@iCollin
Fix/gufm check syntax (#3369)
6f6c864 
* Fix implementation for SDLGetUserFriendlyMessage

* Unit test for SDLGetUserFriendlyMessage: checking syntax

* Changes according to comments

* add invalid syntax error response info

Co-authored-by: ZhdanovP <pzhdanov@luxoft.com>
@iCollin
Forward OnButtonPressNotifications where HMI specifies appID to apps …
ed28151 
…in LIMITED HMI Level (#3378)

* initialize app in non custom button path of on_button_press run

* fixup! initialize app in non custom button path of on_button_press run

fix unit tests with changes in run
@iCollin
unsubscripe app from waypoints when it is unregistered (#3373)
4900a41 
* unsubscripe app from waypoints when it is unregistered

* address review comments

* fix style
@SKobziev @iCollin
Fix messages protocol version check (#2771)
b2ee094 
* Fix messages protocol version check

Fixed the messages protocol version check and
name of ProcessData method parameter 'result' was changed
to 'out_result' for more clarity

* fix copy-paste error and fix style

Co-authored-by: Collin <iCollin@users.noreply.github.com>
Co-authored-by: collin <collin+i@collinmcqueen.com>
@ychernysheva
Rewrite unit tests for PolicyManagerImpl from Proprietary flow (#3352)
f26f647 
* Add new file with unit tests for CacheManager

* Add new tests for PolicyManagerImpl

* Add changes in CMakeLists.txt

* Add new preloaded tables

* Delete unused files

* Re-add test files
@ychernysheva
Rewrite unit tests for PolicyManagerImpl from External flow (#3353)
bad8f0a 
* Add new file with unit tests for CacheManager

* Add new tests for PolicyManagerImpl

* Add new preloaded tables

* Add changes in CMakeLists.txt

* Delete unused files

* Re-add file with test
@jacobkeeler
First version of daemon script from proposal
bd153b1
@ZhdanovP @iCollin
Increase policy unit-tests speed (#2315)
f5cfd15 
* Increase speed for Policy unit-tests: External policy

Increase speed for unit-tests:
- External policy tests
- Regular policy tests

* Increase speed for Policy unit-tests: Regular policy

Co-authored-by: Collin <iCollin@users.noreply.github.com>
@mvorobio
Fix style (#3398)
40d1d3e 
The style has been broken on develop branch - commit f5cfd15
@iCollin
ensure delegates are destroyed before their threads (#3388)
97620cd
IGapchuk and others added 27 commits October 2, 2020 14:09
@IGapchuk
Fix GetInteriorVehicle request wrong processes result codes from HMI (#…
fd291d7 
…3519)

GetInteriorVehicle request RPC should process the next result codes as success:
WRONG_LANGUAGE, RETRY, SAVED.
@IGapchuk
Fix deadlock in policy handler (#3497)
049f7d8
@AKalinich-Luxoft
Fix streamer activity in case of suspend (#3488)
42721d5 
* Fix streamer activity in case of suspend

The problem of the current implementation is that SDL
kills streaming thread responsible for sending a/v
streaming data to HMI when streaming timeout expires.
This issue is observed when mobile app dumps 10-seconds
audio file to SDL during 2 seconds and after that app
does not send any data. In that case HMI will play
audio file during 2 seconds + timeout = 5 seconds. At
the 5th second SDL just kills streaming thread with all
pending messages, however audio service is still open.
As a result not a whole audio file is played.

The correct behavior from SDL side in that case is not
kill streaming thread when streaming timeout was expired.
SDL should kill streaming thread only when service is
actually stopped.

Current SDL behavior was updated to align with a correct
behavior described above.

* Adjust fix to work with audio socket streaming

* Revert "[WIP] initial fix of socket streaming by guessing playback time (#3057)"

This reverts commit 7c442ab.

* Remove unused code after revert

* Fix style issues
@ychernysheva
Add check for already processed resumptions (#3525)
0d53e41
@AKalinich-Luxoft
Fix dead lock in usb connection (#3494)
91f359a 
In a while called method  locks mutex for protecting
data and if USB connection is failed it means that
method will call and will try to lock the same mutex
again. That's why this mutex should be recursive.
@Jack-Byrne
Bugfix 3173 (#3528)
aa4d907 
* Fix 3173 bug:multi-thread access one pointer at same time caused a wild pointer problem in HMICapabilitiesImpl class

* modify test code for 3173

* fix Unit tests

* Fix merge conflicts

Co-authored-by: zhangwenqin <zhangwenqin@iauto.com>
@Jack-Byrne
Re-order rai logic for plugins (#3526)
8539a42 
* Re-order rai logic for plugins

* style

* Add mock method

* Add method descriptions

* Add timing content
@iCollin
use less common port in websocket connection tests (#3529)
6139084
@AKalinich-Luxoft
Fix/usb handler thread safe stop (#3492)
362b3b4 
* Wait for UsbHandler thread end in UsbHandler dtor

The Thread dedicated for handling libusb events should exit
successfully on it's own.

This guarantees that `libusb_close()` being called on all
devices, as well as `libusb_exit()` call is properly sequenced.

Thread exits in recommended by libusb doc way:
  1. set exit flag
  2. deregister hotplug callbacks, which will wake up
     `libusb_handle_events()` once again.

But this commit changes the way the Thread being joined. It
ensures that `join()` is called with `kNoStop` flag, which
prevents force stop using `pthread_cancel()`.

* Using atomic bool for shutdown_requested_ flag

Making UsbHandler::shutdown_requested_ flag atomic to guarantee
mutual access to it.

exchange() call is needed for helgrind to feel sure that there is
no data race.

* Remove redundant DCHECK

This assertion has been exposed by the current fix
@ShobhitAd
Fix/Add DialNumber RPC to preloaded pt (#3533)
87ff1bb 
* Add the DialNumber RPC to the Base-4 and Base-6 functional groups

* Move DialNumber into a separate functional group

* Fix added functional group
@iCollin
remove unlock of lock that isn't locked (#3536)
5c72cdd
@Jack-Byrne
Add error handling for failed hmi message send (#3537)
ad32fca
@ychernysheva
Fix synchronization in WaypointsPendingResumptionHandler (#3531)
4304cc9 
There was a problem with duplicate subscriptions to shared data
due to time gap between check for already subscribed apps in
SDLRPCPlugin and further processing of corresponding requests in
WayPointsPendingResumptionHandler. That's why this check was moved
to WayPointsPendingResumptionHandler.
Also refactoring of some methods WayPointsPendingResumptionHandler
class was done to make their logic clearer and easier to understand.
@ychernysheva
Add check for non-existent parent ID to AddSubMenuRequest (#3534)
3ec2b6b 
* Add check for non-existent parent ID to AddSubMenuRequest

* fixup! Add check for non-existent parent ID to AddSubMenuRequest
@AKalinich-Luxoft
Keep FULL for apps after conflict resolution (#3538)
f1d5756
@jacobkeeler
Fix broken Mobile API link in README
30c08cf
@jacobkeeler
Merge pull request #3548 from smartdevicelink/hotfix/mobile_api_link_…
0ee2d88 
…readme

Fix broken Mobile API link in README
@jacobkeeler
Add defvalue to policy table schema (#3530)
2f98cb8 
* Add defvalue to policy table schema
@ychernysheva
Fix application activation after resumption (#3550)
93d12eb 
* Set is_resuming flag to false

* Change return value in RestoreAppHMIState and StartAppHmiStateResumption
@ychernysheva
Add missed NACK reasons (#3545)
3a9dd1a 
* Add missed NACK reasons, update UTs and add minor changes
@jacobkeeler @ShobhitAd
Fix formatting for logs after logger overhaul (#3554)
7770b07 
* Fix formatting for logs after logger overhaul

Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
@SNiukalov @LuxoftAKutsan
@jacobkeeler @AKalinich-Luxoft
Fix sdl sends unexpected disconnect with resource constraint (#3516)
4f8359f 
* Rework processing of the OnExitApplication

(RESOURCE_CONSTRAINT) notification

* Update UTs according to changes

Co-authored-by: sniukalov <sniukaov@luxoft.com>
Co-authored-by: Aleksandr Kutsan <AKutsan@luxoft.com>
Co-authored-by: jacobkeeler <jacob.keeler@livioradio.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
@Jack-Byrne
Bugfix 2808 copy (#3546)
c0b7d17 
* fix issue 2808:SDL Crash seen in SDL upon receiving rpc - OnEmergencyEvent with enabled:true

* change code stype

* Fix conflicts

* Fix log

* Fix crash

* Address comments

Co-authored-by: zhangwenqin <zhangwenqin@iauto.com>
@AKalinich-Luxoft
Fix a/v streaming retry sequence issues (#3552)
5424645 
There were noticed two issues related to a/v streaming:
1. Due to object self destruction after TerminateRequest() call
any attempt to access member field of that object may cause an
undefined behavior - it might be a core crash or corrupted value
sometimes. In this particular case, SDL tries to access `message_`
field through `application_id()` function after object destruction.
As a result, sometimes SDL crashes and sometimes this function just
returns 0. Because of that, SDL was not able to find application by
zero id and broke the retry sequence. This causes random failures
of some ATF scripts. To avoid that issue, all retry logic was
extracted into the separate function and `TerminateRequest` was
moved after that function. This will guarantee that there is no
attempts to access object fields after its destruction.
2. There was noticed that SDL makes one redundant retry attempt.
That was because of late retry value increment. To fix that issue,
increment has been placed before retry amount check.
@iCollin
remove possibility for invalid choice ID to be sent to mobile (#3555)
69c6067
@iCollin @AKalinich-Luxoft
ensure apps receive default HMI status before activated status (#3559)
80973f4 
* remove cloud app exception from StateControllerImpl::OnApplicationRegistered

* Fix/ Postpone application activation if registration is not complete yet (#3557)

* Postpone application activation if registration is not complete yet

* fixup! Postpone application activation if registration is not complete yet

* fixup! Postpone application activation if registration is not complete yet

Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>

* fix style

* fix unit tests

Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com>
Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
@Jack-Byrne
Update rpc_spec tag for 7.0.0
618a5e0
@Jack-Byrne Jack-Byrne merged commit f270af4 into master Nov 5, 2020
@Jack-Byrne Jack-Byrne deleted the release/7.0.0 branch November 5, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCollin iCollin iCollin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.