CCB: Make refactoring in mb_controller.cc

[LitvinenkoIra]

Bug Report

Race condition in mb_controller.cc

Detailed analysis:

Possible race condition in case of using assignment operator
with atomic variable 'shutdown_', fix via using 'atomic_exchange'.
Incorrect sequence of closing boost asio objects.
Add member function into CMessageBrokerController for correct close sequence.

Reproduction Steps

1. TBD

Expected Behavior

SDL should not crash

Observed Behavior

SDL crashed

OS & Version Information

• OS/Version : SYNC4
• SDL Core Version: https://github.com/smartdevicelink/sdl_core/releases/tag/5.0.1
• Testing Against: SYNC4 Applink

[E-SAITO-TMC]

@joeygrover -san @theresalech -san This issue is a high priority for Toyota. Could you please tell me reproduction steps? Also, Does this issue occur in the latest version?

[theresalech]

Hi @E-SAITO-TMC, we have documented that this is priority for Toyota, and will include for Steering Committee review and vote when planning the contents for the Q4 Core release. This planning will take place in June.
@LitvinenkoIra, can you please provide reproduction steps for this issue? If you could also advise if the Luxoft team is seeing this issue in Core 6.1, that would be most helpful!

[LuxoftAKutsan]

This issue has ho reproduction steps.
It was found by the Hellgrind dynamic code analysis tool in the SYNC environment.
PR to open now available #3381
Regression with automated tests will be performed.

[ShobhitAd]

Closed via #3381