Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCB: Fix data races in TcpClientListener #3187

Closed
LitvinenkoIra opened this issue Dec 6, 2019 · 2 comments
Closed

CCB: Fix data races in TcpClientListener #3187

LitvinenkoIra opened this issue Dec 6, 2019 · 2 comments

Comments

@LitvinenkoIra
Copy link
Contributor

Bug Report

Data races related to TcpClientListener

Detailed analysis:

Type of TcpClientListener::thread_stop_requested_ should be changed from bool to std::atomic_bool.

Reproduction Steps
  1. TBD
Expected Behavior

SDL should not crash

Observed Behavior

SDL crashed

OS & Version Information
@AKalinich-Luxoft AKalinich-Luxoft mentioned this issue Sep 4, 2020
Merged
2 tasks
@AKalinich-Luxoft
Copy link
Contributor

@theresalech fix has been submitted and ready for Livio review

@iCollin
Copy link
Collaborator

iCollin commented Oct 1, 2020

Closed via #3495

@iCollin iCollin closed this as completed Oct 1, 2020
@Jack-Byrne Jack-Byrne mentioned this issue Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AKalinich-Luxoft @iCollin @LitvinenkoIra