Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple media, navigation and non-media apps must be activated during active embedded audio source+audio mixing supported #1917

Closed
6 of 9 tasks
GetmanetsIrina opened this issue Nov 24, 2017 · 9 comments
Labels

Comments

@GetmanetsIrina
Copy link

GetmanetsIrina commented Nov 24, 2017

Occurrence: Always

Description

Multiple media, navigation and non-media apps must be activated during active embedded audio source+audio mixing supported

Preconditions

  • "MixingAudioSupported" = true at .ini file
  • SDL and HMI are started.
  • Three apps running on system:
    a. media app_1 in FULL and AUDIBLE
    b. navigation app_2 in LIMITED and AUDIBLE
    c. non-media app_3 in BACKGROUND and NOT_AUDIBLE
  • User activates embedded audio source and HMILevel of apps were changed to:
    a. media app_1 in BACKGROUND and NOT_AUDIBLE
    b. navigation app_2 in LIMITED and AUDIBLE
  • User activates navigation app_2 -> OnHMIStatus (FULL, AUDIBLE)
  • User activates media app_1 -> FULL, AUDIBLE

Note: embedded audio source was switched off,
navigation app_2 gets (LIMITED, AUDIBLE)

Steps to reproduce

  • User activates non-media app_3
    HMI -> SDL: OnAppDeactivated ( <appID_1> )
    HMI -> SDL: SDL.ActivateApp ( <appID_3 )

Actual result

SDL does not set required HMILevel and audioStreamingState.

Expected result

  1. SDL -> media app_1 : OnHMIStatus (LIMITED, AUDIBLE)
  2. SDL -> HMI: SDL.ActivateApp (SUCCESS)
  3. SDL -> non-media app_3 : OnHMIStatus (FULL, NOT_AUDIBLE).
    Note: navigation app_2 still at LIMITED and AUDIBLE

Environment

Attachments

Expected delivery

  • Source code updates
  • Code comments
  • UTs add/update (not required)
  • ATF tests add/update
  • Manual tests (not required)
  • Add/update CI plans/jobs (not required)
  • SDD updates (not required)
  • Guidelines update (sdl_core_guides) (not required)
  • Guidelines update (sdl_hmi_integration_guidelines) (not required)
@dboltovskyi
Copy link
Contributor

Priority was set to Medium. Issue is related to setting wrong HMI level and/or audioStreamingState for activated application in some specific cases. May affect correct permissions calculation for non-media activated application.

@HSavynetska
Copy link

The issue is relevant on the current develop branch
Environment:
Test script: smartdevicelink/sdl_atf_test_scripts#2088
SDL build: [https://github.com/smartdevicelink/sdl_core/tree/develop] ( e137556 )
ATF: develop branch

@E-SAITO-TMC
Copy link

@joeygrover -san @theresalech -san This issue is a top priority for Toyota. Can the reproduction steps described actually reproduce this issue? Also, Does this issue occur in the latest version?

@theresalech
Copy link
Contributor

Hi @E-SAITO-TMC, we have documented that this is priority for Toyota, and will include for Steering Committee review and vote when planning the contents for the Q4 Core release. This planning will take place in June.
@HSavynetska, can you please advise if you are seeing this issue when using Core 6.1?

@theresalech theresalech added the Waiting for Feedback Maintainers are waiting for feedback from an author or contributor label Apr 23, 2020
@theresalech theresalech added Waiting for Feedback Maintainers are waiting for feedback from an author or contributor and removed Waiting for Feedback Maintainers are waiting for feedback from an author or contributor labels May 13, 2020
@dboltovskyi
Copy link
Contributor

@theresalech Please notice issue is still actual for Core 6.1
ATF script and logs: 2020-06-02_20-50-57_1917.tar.gz

@theresalech
Copy link
Contributor

Hi @dboltovskyi, thank you for the additional information. Will Luxoft be submitting a PR to resolve this issue?

@dboltovskyi
Copy link
Contributor

@theresalech Please notice we're not planning to create the fix in scope of 6.2, though will try to do as much as possible

@theresalech theresalech removed the Waiting for Feedback Maintainers are waiting for feedback from an author or contributor label Jun 11, 2020
@jacobkeeler
Copy link
Contributor

jacobkeeler commented Jul 27, 2020

@GetmanetsIrina @dboltovskyi A point of clarification with this issue.

With the note:

Note: embedded audio source was switched off,
navigation app_2 gets (LIMITED, AUDIBLE)

Wouldn't this require the HMI to disable the AUDIO_SOURCE event before activating the media app for this flow to work properly? I don't see an OnEventChanged(AUDIO_SOURCE, false) message in the provided ATF test. Never mind, it seems the ATF expectations are correct, the issue description just seemed to be a bit ambiguous on the matter.

@jacobkeeler
Copy link
Contributor

Closing with the merge of #3476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants