Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCB: Fix streamer activity in case of suspend #3160

Closed
LitvinenkoIra opened this issue Dec 5, 2019 · 3 comments
Closed

CCB: Fix streamer activity in case of suspend #3160

LitvinenkoIra opened this issue Dec 5, 2019 · 3 comments
Assignees

Comments

@LitvinenkoIra
Copy link
Contributor

LitvinenkoIra commented Dec 5, 2019

Bug Report

SDL stops streaming data by timeout when no new data from mobile received

Detailed analysis:

The problem of the current implementation is that SDL kills streaming thread responsible for sending a/v streaming data to HMI when streaming timeout expires.
This issue is observed when mobile app dumps 10-seconds audio file to SDL during 2 seconds and after that app does not send any data. In that case, HMI will play audio file during 2 seconds + timeout = 5 seconds. At the 5th second SDL just kills streaming thread with all pending messages, however, audio service is still open. As a result, not a whole audio file is played.

The correct behavior from SDL side in that case is not kill streaming thread when streaming timeout was expired. SDL should kill streaming thread only when service is
actually stopped.

Reproduction Steps
  1. Start SDL and modified HMI
  2. Register SPT with type Navi over TCP transport
  3. Activate that app
  4. In SPT go to Menu options on the mobile device --> AV Streaming -->Under Audio Streaming Encrypt Video to NONE --> Start session --> Start Audio
  5. Select 30 sec file and send it to HMI
  6. Wait until the whole audio file is played
Expected Behavior

Should be played whole audio file

Observed Behavior

Audio is played just a few seconds

OS & Version Information

@AKalinich-Luxoft
Copy link
Contributor

@theresalech fix has been submitted and ready for Livio review

@AKalinich-Luxoft AKalinich-Luxoft self-assigned this Sep 4, 2020
@AKalinich-Luxoft
Copy link
Contributor

AKalinich-Luxoft commented Oct 2, 2020

Issue as described was fixed by #3057.

Issue title and PR #3488 seem to suggest there is a problem when a stream is suspended, can you please update the reproduction steps and/or description to reflect that?

PR #3057 is just solves audio playback issue on socket transport. PR #3488 suggest another solution for all the transports
I also updated reproduction steps for OpenSDL

@iCollin
Copy link
Collaborator

iCollin commented Oct 5, 2020

Closed via #3488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants