Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDL 0242] Subtle Alert Style #2969

Closed
theresalech opened this issue Jul 22, 2019 · 3 comments
Closed

[SDL 0242] Subtle Alert Style #2969

theresalech opened this issue Jul 22, 2019 · 3 comments
Labels
proposal Accepted SDL Evolution Proposal

Comments

@theresalech
Copy link
Contributor

Proposal: Subtle Alert Style

This feature adds the SubtleAlert RPC, which presents a style of alert: the "subtle" alert. This is a "notification style" alert that does not take over the entire screen.

Review: smartdevicelink/sdl_evolution#777

Steering Committee Decision:

The Steering Committee voted to accept this proposal with the following revision: update to use alternate approach 1, for the reasons identified in this comment from the Project Maintainer.

The proposal .md file was updated to reflect these revisions on 7/22/19.
@theresalech theresalech added the proposal Accepted SDL Evolution Proposal label Jul 22, 2019
@jacobkeeler jacobkeeler mentioned this issue Jul 8, 2020
Merged
1 task
@theresalech
Copy link
Contributor Author

Proposal markdown file has been updated per the revisions included in accepted Evolution Proposal SDL 0242 Revisions - Subtle Alert Style. Revisions include updating several RPC definitions, and adding a policy field to control rate limiting for SubtleAlert requests as is currently available for Alert requests. Please reference the issue and proposal markdown file for revisions details.

@theresalech theresalech mentioned this issue Jul 22, 2020
Closed
@theresalech
Copy link
Contributor Author

Proposal markdown file has been updated per the revisions included in accepted Evolution Proposal SDL 0242 Revisions - Subtle Alert Style. Revisions include adding a SubtleAlertresponse, including all basic response parameters as well as tryAgainTime. Please reference the issue and proposal markdown file for revisions details.

@theresalech theresalech mentioned this issue Aug 5, 2020
Closed
@jacobkeeler
Copy link
Contributor

Closing with the merge of #3459

@Jack-Byrne Jack-Byrne mentioned this issue Oct 22, 2020
Merged
@jacobkeeler jacobkeeler mentioned this issue Nov 4, 2020
Merged
@Jack-Byrne Jack-Byrne mentioned this issue Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal Accepted SDL Evolution Proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobkeeler @theresalech