Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected TTS.StopSpeaking request is requested during processing two Alert requests #3563

Closed
GetmanetsIrina opened this issue Nov 4, 2020 · 1 comment

Comments

@GetmanetsIrina
Copy link

GetmanetsIrina commented Nov 4, 2020

Bug Report

SDL sends unexpected TTS.StopSpeaking request is requested during processing two Alert requests

Precondition
  1. Start WebHMI and SDL
  2. Connect mobile device and consent it
  3. Register app from mobile device
  4. Activate the app
Reproduction Steps
  1. Send Alert request with TTS portion from the app
  2. Send another Alert request with TTS portion from the app during the duration of Alert RPC displaying from the previous step

Note: Issue is also related to SubtleAlert

Expected Behavior
  1. HMI responds with code 4 (REJECTED) to requests related to the second Alert request
  2. SDL does not send TTS.StopSpeaking for TTS.Speak related to the first Alert request after receiving erroneous responses to requests related to the second Alert request
Observed Behavior

SDL aborts TTS.Speak request related to the first Alert via TTS.StopSpeaking

SDL -> HMI [17:20:56:367]: {"id":41,"jsonrpc":"2.0","method":"UI.Alert","params":{"alertStrings":[{"fieldName":"alertText1","fieldText":"Alert Line 1"},{"fieldName":"alertText2","fieldText":"Alert Line 2"},{"fieldName":"alertText3","fieldText":"Alert Line 3"}],"alertType":"BOTH","appID":1401473654,"cancelID":0,"duration":10000,"progressIndicator":true}}

UIRPC.js:157 FFW.UI.onRPCRequest
UIRPC.js:2097 FFW.UI.OnSystemContext
RPCClient.js:323 HMI -> SDL [17:20:56:379]: {"jsonrpc":"2.0","method":"UI.OnSystemContext","params":{"systemContext":"ALERT","appID":1401473654}}
RPCClient.js:137 SDL -> HMI [17:20:56:407]: {"id":42,"jsonrpc":"2.0","method":"TTS.Speak","params":{"appID":1401473654,"playTone":true,"speakType":"ALERT","ttsChunks":[{"text":"Text to Speak","type":"TEXT"}]}}

TTSRPC.js:143 FFW.TTS.onRPCRequest
TTSRPC.js:444 FFW.TTS.Started
RPCClient.js:323 HMI -> SDL [17:20:56:408]: {"jsonrpc":"2.0","method":"TTS.Started"}
RPCClient.js:137 SDL -> HMI [17:20:58:239]: {"id":43,"jsonrpc":"2.0","method":"UI.Alert","params":{"alertStrings":[{"fieldName":"alertText1","fieldText":"Alert Line 1"},{"fieldName":"alertText2","fieldText":"Alert Line 2"},{"fieldName":"alertText3","fieldText":"Alert Line 3"}],"alertType":"BOTH","appID":1401473654,"cancelID":0,"duration":10000,"progressIndicator":true}}

UIRPC.js:157 FFW.UI.onRPCRequest
UIRPC.js:1804 FFW.UI.AlertResponse
UIRPC.js:1725 FFW.UI.AlertResponse
RPCClient.js:323 HMI -> SDL [17:20:58:240]: {"jsonrpc":"2.0","id":43,"error":{"code":4,"message":"Another Alert is active.","data":{"method":"UI.Alert"}}}
RPCClient.js:137 SDL -> HMI [17:20:58:244]: {"id":44,"jsonrpc":"2.0","method":"TTS.Speak","params":{"appID":1401473654,"playTone":true,"speakType":"ALERT","ttsChunks":[{"text":"Text to Speak","type":"TEXT"}]}}

TTSRPC.js:143 FFW.TTS.onRPCRequest
TTSRPC.js:358 FFW.TTS.SpeakResponse
RPCClient.js:323 HMI -> SDL [17:20:58:245]: {"jsonrpc":"2.0","id":44,"error":{"code":4,"message":"TTS in progress. Rejected.","data":{"method":"TTS.Speak"}}}
RPCClient.js:137 SDL -> HMI [17:20:58:247]: {"id":45,"jsonrpc":"2.0","method":"TTS.StopSpeaking"}

TTSRPC.js:143 FFW.TTS.onRPCRequest
TTSRPC.js:358 FFW.TTS.SpeakResponse
RPCClient.js:323 HMI -> SDL [17:20:58:248]: {"jsonrpc":"2.0","id":42,"error":{"code":5,"message":"TTS Speak request aborted","data":{"method":"TTS.Speak"}}}
TTSRPC.js:471 FFW.TTS.Stopped
RPCClient.js:323 HMI -> SDL [17:20:58:248]: {"jsonrpc":"2.0","method":"TTS.Stopped"}
TTSRPC.js:404 FFW.TTS.TTS.StopSpeakingResponse
RPCClient.js:323 HMI -> SDL [17:20:58:249]: {"jsonrpc":"2.0","id":45,"result":{"code":0,"method":"TTS.StopSpeaking"}}
UIRPC.js:1804 FFW.UI.AlertResponse
UIRPC.js:1774 FFW.UI.UI.AlertResponse
RPCClient.js:323 HMI -> SDL [17:21:6:381]: {"jsonrpc":"2.0","id":41,"result":{"code":0,"method":"UI.Alert"}}
UIRPC.js:2097 FFW.UI.OnSystemContext
RPCClient.js:323 HMI -> SDL [17:21:6:384]: {"jsonrpc":"2.0","method":"UI.OnSystemContext","params":{"systemContext":"MAIN","appID":1401473654}}
OS & Version Information
SDL log

SDL_SubtleAlert_speak_aborted.log

@Jack-Byrne
Copy link
Collaborator

Jack-Byrne commented Jul 19, 2021

Issue related to hmi implementation. Fixed by smartdevicelink/sdl_hmi#464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants