Fix responses sequence for Alert and SubtleAlert #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ypostolov
approved these changes
Nov 11, 2020
AKalinich-Luxoft
force-pushed
the
fix/fix_subtle_alert_reject_sequence
branch
from
b2f957f
to
c34cec9
Compare
AKalinich-Luxoft
force-pushed
the
fix/fix_subtle_alert_reject_sequence
branch
from
c34cec9
to
69b119f
Compare
|
@AKalinich-Luxoft I noticed there is an approval on the PR from the Luxoft team. Is this PR ready for Livio review? |
|
@jordynmackool, currently the PR is not ready for Livio review. |
…_alert_reject_sequence
|
@jordynmackool all conflicts have been resolved and PR is ready for Livio review |
|
@AKalinich-Luxoft Does this fix mean that smartdevicelink/sdl_core#3563 can be closed? |
@JackLivio yes, SDL issue can be closed as its behavior is correct in this case |
Jack-Byrne
approved these changes
Jul 19, 2021
ValeriiMalkov
pushed a commit
to LuxoftSDL/sdl_hmi
that referenced
this pull request
Jul 21, 2021
* Add TTS.Speak callbacks handlers and generic logic * Added postponed callback for UI.Alert * Added postponed callback for UI.SubtleAlert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #465
This PR is ready for review.
Testing Plan
Covered by manual test plan
Summary
There was noticed an issue #3563 when SDL sends unexpected
TTS.StopSpeakingrequest to HMI. This is a correct SDL behavior according to requirements for case when SDL receives response on UI part ofAlert/SubtleAlertBEFORE receiving response onTTS.Speakpart of request. HMI has been implemented in a way to send responses on UI part right away after receiving, so this sequence triggers SDL to stop TTS from it's side explicitly, however corresponding speak request was even not started yet.To fix that sequence, added logic to postpone responses for
UI.AlertandUI.SubtleAlertif TTS part is expected from SDL. In that case, if by some reason request is being rejected and TTS part is expected, HMI will registerTTS.Speaklistener and send response to UI part only after sending response to TTS part. In that case SDL will not send redundantTTS.StopSpeakingrequest to HMI.Note TTS part of request for
Alert/SubtleAlertcan be predicted by HMI byalertTypeparameter of UI part. However, there is no way to predict the same forAlertManeuverandPerformAPTRPCs. Probably, this is a good candidate for a new proposal.CLA