Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs to allow build with gcc 7.2.0 under Ubuntu 17.10 #1851

Closed
wants to merge 2 commits into from
Closed

fix bugs to allow build with gcc 7.2.0 under Ubuntu 17.10 #1851

wants to merge 2 commits into from

Conversation

asanoaozora
Copy link

Fixes #[3]

This PR is [ready] for review.

Risk

This PR makes [no] API changes.

Testing Plan

[After successful built, /.start.sh and chromium-browser index.html, the html page displayed]

Summary

[To build it under Ubuntu with gcc 7.2.1, somes fix have been necessary to apply]

Changelog

Breaking Changes
  • [Breaking change info]
Enhancements
  • [Enhancement info]
Bug Fixes
  • [Error on apache_log4cxx fixed by applying patches of the version log4cxx_0.10.0-11.debian.tar.xz]
    *[enum returned in a bool->replaced by false]
    *[unused but set variable -> commented]

Tasks Remaining:

  • [Task 1]
  • [Task 2]

CLA

LuxoftAKutsan
LuxoftAKutsan reviewed Nov 9, 2017
View reviewed changes
src/components/application_manager/src/policies/policy_handler.cc Outdated
@@ -1768,7 +1768,7 @@ void PolicyHandler::OnCertificateUpdated(const std::string& certificate_data) {
void PolicyHandler::OnPTUFinished(const bool ptu_result) {
LOG4CXX_AUTO_TRACE(logger_);
sync_primitives::AutoLock lock(listeners_lock_);
HandlersCollection::const_iterator it = listeners_.begin();
// HandlersCollection::const_iterator it = listeners_.begin();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asanoaozora please remove unused code. Do not leave it commented.

@asanoaozora
Copy link
Author

Done, rebuilt, launch the core and the html page successfully, except these messages size inconsistency (?)
$ ./start.sh
accept_buf: /Ekd//GI6983yqQUZB4Ajw8ItSg=
accept_buf: z0o8u0AunK4Fjgjp1cHlvyx3/J4=
accept_buf: gnwd3huJXT2/cCSyM1XS8jm+sXY=
accept_buf: 3NdM0dp28sRnU/cuqkF4aTXz5uM=
accept_buf: J4+v2cg6DIvndegKJxhvWVDAU/4=
accept_buf: 9pBIrHTQVOxILXDOmr1r6izAIao=
accept_buf: 9N8CdO5ZbmChCxxyM9yqGFOyOTM=
accept_buf: Sg6+eMckqBUSYiF9gmG5k1LxVvk=
ERROR!!! ~/github/sdl_core/src/3rd_party-static/message_broker/src/server/mb_tcpserver.cpp:96 Received 4096 actual data length 4916
ERROR!!! ~/github/sdl_core/src/3rd_party-static/message_broker/src/server/mb_tcpserver.cpp:97 Incomplete message
ERROR!!! ~/github/sdl_core/src/3rd_party-static/message_broker/src/server/mb_tcpserver.cpp:96 Received 4096 actual data length 4916
^CERROR!!! ~/github/sdl_core/src/3rd_party-static/message_broker/src/server/mb_tcpserver.cpp:97 Incomplete message

phongt added a commit to phongt/meta-sdl that referenced this pull request Dec 29, 2017
@phongt
apply patches for gcc 7
9406b23 
Apply this pull request.
smartdevicelink/sdl_core#1851

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
@JenkinsSDLOnCloud
Copy link

Can one of the admins verify this patch?

@jacobkeeler
Copy link
Contributor

@asanoaozora Please sign the CLA and mark it as complete. Also, please reference an issue that this change fixes (I don't know where you got #3 from, but it needs to be an issue within this repository), it looks like this may resolve #1495

@jacobkeeler
Copy link
Contributor

Closing in favor of #2097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuxoftAKutsan LuxoftAKutsan LuxoftAKutsan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asanoaozora @JenkinsSDLOnCloud @jacobkeeler @LuxoftAKutsan