Remove QT HMI API and QT specific RPCs #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobkeeler
force-pushed
the
feature/remove_qt_hmi_api_dbus
branch
from
bf5beda
to
5ad3996
Compare
…into develop # Conflicts: # src/components/application_manager/CMakeLists.txt # src/components/application_manager/include/application_manager/commands/mobile/get_vehicle_data_request.h # src/components/application_manager/include/application_manager/commands/mobile/subscribe_vehicle_data_request.h # src/components/application_manager/include/application_manager/commands/mobile/unsubscribe_vehicle_data_request.h # src/components/application_manager/src/commands/mobile/get_vehicle_data_request.cc # src/components/application_manager/src/commands/mobile/subscribe_vehicle_data_request.cc # src/components/application_manager/src/commands/mobile/unsubscribe_vehicle_data_request.cc # src/components/application_manager/src/hmi_command_factory.cc # src/components/application_manager/src/message_helper/message_helper.cc # src/components/application_manager/test/commands/hmi/dummy_hmi_commands_test.cc # src/components/application_manager/test/commands/hmi/hmi_notifications/hmi_notifications_test.cc # src/components/application_manager/test/commands/mobile/get_vehicle_data_request_test.cc
jacobkeeler
force-pushed
the
feature/remove_qt_hmi_api_dbus
branch
from
5ad3996
to
b8d3227
Compare
Jack-Byrne
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1857
This PR is ready for review.
Risk
This PR makes major API changes.
Summary
Removes QT HMI and any logic tied to it, along with the DBus library dependency.
Changelog
Breaking Changes
Get[SomeVehicleData]RPCs)Enhancements
Tasks Remaining:
CLA