Feature/gps shift support #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current commit contains changes for MOBILE_API and HMI_API. For the China region, GPS data have to be corrected in order to bridge the gap between different standards used. API changes introduce "shifted" flag for GPS data which defines whether the GPS data (latitude, longitude, attitude, timestamp) raw or already adjusted. The new parameter will let the phone app know, whether the data have to be compensated.
Added SisData structure to rc_module_constants. Extended GetInteriorVehicleDataRequestTest with GPS data.
mkorniichuk
requested review from
AKalinich-Luxoft,
Itileda,
LuxoftAKutsan,
Ypostolov,
BSolonenko,
a user,
ZhdanovP and
mked-luxoft
AKalinich-Luxoft
suggested changes
Oct 24, 2018
| smart_objects::SmartObject sis_data; | ||
| smart_objects::SmartObject gps_data; | ||
|
|
||
| const char kGpsShifted[] = "shifted"; |
There was a problem hiding this comment.
@mkorniichuk propose to move this constant to the file namespace. Otherwise it's better to rename it to shifted_param as for local variables we have a different naming rules
Added GPSData structure to rc_module_constants.
BSolonenko
approved these changes
Oct 28, 2018
AKalinich-Luxoft
approved these changes
Oct 29, 2018
ZhdanovP
approved these changes
Oct 31, 2018
mked-luxoft
approved these changes
Oct 31, 2018
LuxoftAKutsan
approved these changes
Oct 31, 2018
ghost
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2639
This PR is ready for review.
Risk
This PR makes major API changes.
Testing Plan
Unit testing.
Summary
Current commit contains changes for MOBILE_API and HMI_API.
For the China region, GPS data have to be corrected in order to
bridge the gap between different standards used.
Changelog
Breaking Changes
(latitude, longitude, attitude, timestamp) raw or already adjusted.
Tasks Remaining:
CLA