Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/GPS Shift support #2741

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Feature/GPS Shift support #2741

merged 5 commits into from
Jun 28, 2019

Conversation

mkorniichuk
Copy link
Contributor

@mkorniichuk mkorniichuk commented Nov 7, 2018 •
edited
Loading

Fixes #2639

This PR is ready for review.

Risk

This PR makes major API changes.

Testing Plan

Unit testing.

Summary

Current commit contains changes for MOBILE_API and HMI_API.
For the China region, GPS data have to be corrected in order to
bridge the gap between different standards used.

Changelog

Breaking Changes
  • API changes introduce "shifted" flag for GPS data which defines whether the GPS data
    (latitude, longitude, attitude, timestamp) raw or already adjusted.

Tasks Remaining:

  • Unit tests

Other parts of delivery:

CLA

LuxoftAKutsan
LuxoftAKutsan reviewed Nov 7, 2018
View reviewed changes
...ts/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/rc_module_constants.h Outdated
const char kLongitudeDegrees[] = "longitudeDegrees";
const char kLatitudeDegrees[] = "latitudeDegrees";
const char kUtcYear[] = "utcYear";
const char kUtcMonth[] = "utcMonth";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkorniichuk where do we use all this constants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuxoftAKutsan For now, some of them are used for unit testing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkorniichuk please keep only constants that are used ( only in UT is OK)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuxoftAKutsan fixed within dc543a1

@mkorniichuk mkorniichuk changed the title GPS shift support Feature/GPS shift support Nov 12, 2018
@vkushnirenko-luxoft
Copy link
Contributor

Rebuild required

@mkorniichuk mkorniichuk force-pushed the feature/gps_shift_support branch 2 times, most recently from 4986eb8 to bd1a994 Compare May 22, 2019 14:25
@mkorniichuk mkorniichuk changed the title Feature/GPS shift support [SDL 0199]-Adding-GPS-Shift-support May 23, 2019
@mkorniichuk mkorniichuk changed the title [SDL 0199]-Adding-GPS-Shift-support Feature/GPS Shift support May 23, 2019
yang1070
yang1070 approved these changes May 30, 2019
View reviewed changes
Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ford has reviewed and approved this PR.

@mkorniichuk
Copy link
Contributor Author

@ShobhitAd all the comments are processed. Please, take a look

@ShobhitAd
Copy link
Contributor

ShobhitAd commented Jun 11, 2019 •
edited
Loading

Waiting to test implementation against sdl_ios and/or sdl_java_suite before merging into develop

@AStasiuk
Copy link

@ShobhitAd Could you please clarify, is this testing should be done by Project Maintaner?

mkorniichuk and others added 3 commits June 11, 2019 18:46
@mkorniichuk
GPS shift support implementation
0f08ba7
@mkorniichuk
Filtering unnecessary GPS data in SisData
e0643dd 
The filter created to manage data in terms of SisData->StationLocation->GPSData,
since GPSData should not contain more params then latitude, longitude, altitude
@LuxoftAKutsan @ShobhitAd @mkorniichuk
Update src/components/application_manager/rpc_plugins/rc_rpc_plugin/i…
a95f34b 
…nclude/rc_rpc_plugin/rc_helpers.h

Fix typo

Update src/components/interfaces/MOBILE_API.xml

Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
@mkorniichuk
Copy link
Contributor Author

Rebased onto current develop 7a7c31b. Made more suitable commit history

@mrapitis
Copy link
Contributor

Mobile side PR's are available below:
smartdevicelink/sdl_ios#1299
smartdevicelink/sdl_java_suite#1091

@ShobhitAd
Copy link
Contributor

@ShobhitAd Could you please clarify, is this testing should be done by Project Maintaner?

@AStasiuk Yes, this testing will be done by the Project Maintainer

@AStasiuk
Copy link

@ShobhitAd, please let me know if you need any kind of assistance with the testing of this feature.
According to this comment sdl_ios and/or sdl_java_suite PR's are available.

@ShobhitAd ShobhitAd merged commit 18ca3b7 into develop Jun 28, 2019
@ShobhitAd ShobhitAd mentioned this pull request Jul 8, 2019
Closed
@jacobkeeler jacobkeeler deleted the feature/gps_shift_support branch February 19, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuxoftAKutsan LuxoftAKutsan LuxoftAKutsan approved these changes

@yang1070 yang1070 yang1070 approved these changes

@ShobhitAd ShobhitAd ShobhitAd approved these changes

@mrapitis mrapitis Awaiting requested review from mrapitis

@robinmk robinmk Awaiting requested review from robinmk

@jacobkeeler jacobkeeler Awaiting requested review from jacobkeeler

@Jack-Byrne Jack-Byrne Awaiting requested review from Jack-Byrne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mkorniichuk @vkushnirenko-luxoft @ShobhitAd @AStasiuk @mrapitis @LuxoftAKutsan @yang1070