Add missing internal error codes to security manager #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Byrne
reviewed
Sep 13, 2021
Co-authored-by: JackLivio <jack@livio.io>
Jack-Byrne
reviewed
Sep 13, 2021
| @@ -759,7 +760,15 @@ TEST_F(SecurityManagerTest, ProcessHandshakeData_Answer) { | |||
| RawMessageEqSize(raw_message_size), false, kIsFinal)) | |||
| .Times(handshake_emulates) | |||
| .WillRepeatedly(NotifyTestAsyncWaiter(waiter)); | |||
| times += handshake_emulates; | |||
There was a problem hiding this comment.
Please add unit test cases for other possible error codes added in this pr
Jack-Byrne
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing security query specification details from smartdevicelink/protocol_spec#40
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
HANDSHAKE_FAILED - can be triggered by setting
VerifyPeer=trueusing the Java Security Lib Example CertificatesINVALID_CERT - can be triggered by sending an app certificate with an app ID which is different from the one that the app registered with
EXPIRED_CERT - can be triggered by sending an expired app certificate (or by modifying the GetSystemTime response from the HMI)
Summary
Adds logic for missing error codes in SendInternalError query (HANDSHAKE_FAILED, ERROR_INVALID_CERT, and ERROR_EXPIRED_CERT)
Changelog
Bug Fixes
CLA