use files from the rps_spec folder without copying to the sdl_core #3778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jordynmackool This PR is ready for Livio review |
|
@RomanReznichenkoLuxoft can you please provide an issue number that this PR is fixing? If no issue currently exists, please add an issue (https://github.com/smartdevicelink/sdl_core/issues/new). Thanks! |
|
@theresalech Please find a new issue #3779. Description of this PR has updated accordingly. |
iCollin
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3779
This PR is ready for review.
Risk
This PR makes no API changes.
Summary
We copied files from rpc_spec to sdl_core/src/components/interfaces. Now we use MOBILE_API.xml from submodule rpc_spec instead of copied for classes generation
CLA