Conditions to transfer on button press on button event #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review: @dtrunov , @anosach-luxoft , @LuxoftAKutsan ,@VVeremjova, @orhan-mehmedov |
|
@TMelnyk, Please review HMI_API.xml file |
|
reviewed |
|
@OHerasym Reviewed |
1 similar comment
|
@OHerasym Reviewed |
| SendButtonPress(subscribed_app); | ||
| } else if (subscribed_app->IsFullscreen()) { | ||
| // if No "appID" - send it FULL apps only. | ||
| SendButtonPress(subscribed_app); |
There was a problem hiding this comment.
@OHerasym, seems there are same actions in "if" and in "else if". Can it be just one "if"? (is there important side effects in IsFullscreen?)
There was a problem hiding this comment.
@orhan-mehmedov, 7073b13, Done
|
@OHerasym Reviewed |
| @@ -57,6 +57,9 @@ void OnButtonEventNotification::Run() { | |||
| static_cast<uint32_t>( | |||
| (*message_)[strings::msg_params][hmi_response::button_name].asInt()); | |||
|
|
|||
| ApplicationSharedPtr app = ApplicationManagerImpl::instance()->application( | |||
There was a problem hiding this comment.
@OHerasym can app be const?
There was a problem hiding this comment.
@LuxoftAKutsan , b4e3de2 , Done
|
Reviewed |
1 similar comment
|
Reviewed |
Related: APPLINK-25470
Related: APPLINK-25470
Related: APPLINK-25470
davidswi
pushed a commit
to davidswi/sdl_core
that referenced
this pull request
Oct 25, 2017
…4.1 to develop * commit 'a23e449ffbcab3e0f82d5317ba3e9579396f0b3c': (673 commits) SDL-715 fixing button issue for media apps SDL-627 fixing onHMIstatus issue Revert "SDL-627 iOS onHMIstatus NONE issue" SDL-627 iOS onHMIstatus NONE issue Fix SQLite3 include path / SDL-628 fixing policy continue to update issue fixing iOS tranport issue fixing logging issue deleting duplicate folder fixing build break fixing build errors Make code appropriate to Google coding style Conditions to transfer on button press on button event (smartdevicelink#775) Update logger properties to log to file only Change_VerifyPeer_parameter_in_ini_file_to_true Fix application add to app_level table Send OnHashChange for (Un)SubscribeWayPoints Fix_core_dump_due_to_connection_been_created_twice Removes odd calls to valid() and changed functor Fixes includes and logs ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Changes:
Related: APPLINK-25470
Old pull request