Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sdl 0188 interior vehicle data resumption #96

Conversation

LuxoftAKutsan
Copy link
Contributor

@LuxoftAKutsan LuxoftAKutsan commented Aug 20, 2020

Fixes 1480

⚠️ PR depends on #94

This PR is ready for review.

Risk

N/A

Testing Plan

N/A

Summary

Add interior vehicle data to the resumption

CLA


note over ExtensionPendingResumptionHandler
Responsible for watching if subscription
to any data already sent
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sent to HMI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and prevent sending dublicate
end note

RAI1 -> ResumptionDataProcessor : StartResumption
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove RAI. reaple with RAI1 or RAI2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,82 @@
@startuml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show explicit that is app2 is subsribed not another data, appropriate HMI request will be sent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuxoftAKutsan LuxoftAKutsan force-pushed the feature/sdl_0188_interior_vehicle_data_resumption branch from f8d03d2 to 10a4409 Compare August 20, 2020 16:21
@KhrystynaDubovyk
Copy link
Contributor

@yang1070 please, see the updates made

Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note this PR also include the changes for SDL-190. Please re-base the PR after changes for SDL-190 get merged.

We reviewed this pull request, especially the section relate only to SDL-188 during online meeting. All the comments are addressed and questions are answered. The final changes look good to me.

Ford team approves this change regarding SDL188.

@KhrystynaDubovyk
Copy link
Contributor

@theresalech PR is ready for Livio review. Thank you!

@KhrystynaDubovyk
Copy link
Contributor

@ShobhitAd, the conflicts were resolved. The PR is ready for merging.

@ShobhitAd ShobhitAd merged commit 362d69b into smartdevicelink:develop Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants