Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accepted] SDL 0049 - Gesture cancellation on video streaming #144

Closed
theresalech opened this issue Apr 5, 2017 · 6 comments
Closed

[Accepted] SDL 0049 - Gesture cancellation on video streaming #144

theresalech opened this issue Apr 5, 2017 · 6 comments

Comments

@theresalech
Copy link
Contributor

Hello SDL community,

The review of "Gesture cancellation on video streaming" begins now and runs through April 11, 2017. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0049-touch-cancellation.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#144

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

  • Is the problem being addressed significant enough to warrant a change to SDL?
  • Does this proposal fit well with the feel and direction of SDL?
  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
    Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Theresa Lech

Program Manager - Livio
theresa@livio.io

@tpulatha
Copy link
Contributor

tpulatha commented Apr 5, 2017

What is the difference between END and the new proposed CANCEL touchevent type?
Wouldn't the HMI just send END if a current gesture gets interrupted?
Because effectively, if the user is dragging.. we don't want to "cancel" the drag (which would mean to move back to the start of the drag) but just "end" the dragging, right?

@masatoogawa
Copy link

masatoogawa commented Apr 6, 2017

@tpulatha Thank you for your prompt review. END is the end of input by a user. CANCEL is an interruption of the input by system.

if the user is dragging..

For example, in the case of tap gestures, END may be a decision behavior.

  1. A user taps on the screen. BEGIN is sent to an application.
  2. A user keeps on tapping. A native dialog interrupts.
  3. A user keeps on tapping. END is sent to an application.

An application may decide END which system send is a decision action even a user does not release his finger.

"cancel" the drag (which would mean to move back to the start of the drag)

CANCEL expects not to rewind touch position but to cancel gesture recognition.

@joeljfischer
Copy link
Contributor

@tpulatha I think what they're trying to say, for example: the user is in the middle of a pinch gesture, a popup appears. If END is sent, the pinch will register, which is not intended. If CANCEL is sent, the pinch should be discarded.

The problem I see with this is that I'm not sure it's necessary. A pinch or drag generally occurs in real time, and simply using END seems appropriate. I'm not sure of what touch event use case would occur where a popup appearing would require a CANCEL and not simply an END. A long-press is the only one I can think of that might be relevant? It may be possible to get a short-press when a long was intended?

@masatoogawa
Copy link

For example, we have drag and drop in the user case.

Although they are edge cases, there are possibilities where END causes a decision action. We believe that introducing CANCEL is reasonable.

@theresalech theresalech changed the title [In Review] SDL 0049 - Gesture cancellation on video streaming [Accepted] SDL 0049 - Gesture cancellation on video streaming Apr 12, 2017
@theresalech
Copy link
Contributor Author

The Steering Committee has agreed to accept this proposal, citing the drag and drop example as a valid use case.

@smartdevicelink smartdevicelink locked and limited conversation to collaborators Apr 12, 2017
@theresalech
Copy link
Contributor Author

theresalech commented Apr 12, 2017

Issues entered:
Core
Android
iOS
RPC

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants