-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL-0188 Interior Vehicle Data resumption revision #1062
SDL-0188 Interior Vehicle Data resumption revision #1062
Conversation
@theresalech please review this proposal revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ford approves this proposal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuxoftAKutsan, since this is a request to revise a previously accepted proposal, please update the PR description to follow the format of the proposal template. See more information on revising previously accepted proposals here, and an example of how to format this type of pull request here. Thank you!
@theresalech fixed description. Added paragraphs that were changed |
@LuxoftAKutsan, thanks for your updates. However, the PR description still needs to be changed to match the format of a proposal template, and include all sections (Motivation, Proposed solution, Potential downsides, etc.). Please see this example: #775. |
@theresalech sorry for confusion. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuxoftAKutsan, thanks very much! Can you please make the following updates within the PR description? Let me know if you have any questions or concerns. Thanks again!
(1) In the Introduction
section:
Updating SDL-0188 Interior Vehicle Data resumption revision in scope of fixing typos to match rpc_spec.
should be
Update "SDL-0188 Interior Vehicle Data resumption." The revision is in the scope of fixing typos to match the RPC Spec.
(2) In the Proposed solution
section:
Fixing parameter names for GetInteriorVehicleData from
IsSubscribe
tosubscribe
according existing API.
In
behavior changes
block replacedSetInteriorVehicleData
withGetInteriorVehicleData
RPC that was initially meant.
should be
Fix parameter names for GetInteriorVehicleData from
IsSubscribe
tosubscribe
according to the existing API.
In
behavior changes
block, replaceSetInteriorVehicleData
with theGetInteriorVehicleData
RPC that was initially meant.
@theresalech fixed |
@theresalech Update : newer mind reverted this fix to avoid confusion on SDLC |
6dca09c
to
bd72b67
Compare
@LuxoftAKutsan, if you would like to see additional changes in the proposed revision, please leave those as a comment on the proposal review issue, here: #1072. This will allow all SDLC members to review and consider in their vote on this revision during our next Steering Committee meeting. Thanks! |
Introduction
Update "SDL-0188 Interior Vehicle Data resumption." The revision is in the scope of fixing typos to match the RPC Spec.
Motivation
Fix typos to avoid confusion in further activities.
Proposed solution
Fix parameter names for GetInteriorVehicleData from
IsSubscribe
tosubscribe
according to the existing API.In behaviour changes block, replace
SetInteriorVehicleData
with theGetInteriorVehicleData
RPC that was initially meant.Potential downsides
N/A
Impact on existing code
N/A
Alternatives considered
N/A