Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMI sends invalid TTS.Speak response in case PerformInteraction has been requested without Initial Prompt #502

Closed
GetmanetsIrina opened this issue Mar 10, 2021 · 1 comment
Labels

Comments

@GetmanetsIrina
Copy link

Description:
HMI sends invalid TTS.Speak response in case PerformInteraction has been requested without Initial Prompt parameter

Occurrence: 100%

Preconditions:

  1. Start WebHMI and SDL
  2. Connect the mobile device and consent it if needed
  3. Register app from the mobile device
  4. Activate the app

Steps to reproduce:

  1. Send PerformInteraction without Initial Prompt parameter

Expected result:
There are no invalid messages during PerformInteraction RPC processing

Observed behavior:
HMI send redundant invalid TTS.Speak response during PerformInteraction request processing

SDL -> HMI [11:55:31:397]: {"id":177,"jsonrpc":"2.0","method":"VR.PerformInteraction","params":{"appID":1214726483,"cancelID":0,"helpPrompt":[{"text":"Help prompt","type":"TEXT"}],"timeout":10000,"timeoutPrompt":[{"text":"Timeout prompt","type":"TEXT"}]}}
VRRPC.js:141 FFW.VR.onRPCRequest
TTSRPC.js:304 FFW.TTS.SpeakResponse
RPCClient.js:323 HMI -> SDL [11:55:31:404]: {"jsonrpc":"2.0","id":null,"error":{"code":21,"message":"No TTS Chunks provided in Speak request","data":{"method":"TTS.Speak"}}}
VRRPC.js:373 FFW.VR.VR.PerformInteractionResponse
RPCClient.js:323 HMI -> SDL [11:55:31:406]: {"jsonrpc":"2.0","id":177,"result":{"code":0,"method":"VR.PerformInteraction"}}
RPCClient.js:137 SDL -> HMI [11:55:31:409]: {"id":178,"jsonrpc":"2.0","method":"UI.PerformInteraction","params":{"appID":1214726483,"cancelID":0,"choiceSet":[{"choiceID":1,"menuName":"Choice1"}],"initialText":{"fieldName":"initialInteractionText","fieldText":"Pick number:"},"interactionLayout":"ICON_ONLY","timeout":10000}}
UIRPC.js:157 FFW.UI.onRPCRequest
UIRPC.js:2076 FFW.UI.OnSystemContext
RPCClient.js:323 HMI -> SDL [11:55:31:417]: {"jsonrpc":"2.0","method":"UI.OnSystemContext","params":{"systemContext":"HMI_OBSCURED","appID":1214726483}}
TTSRPC.js:405 FFW.TTS.Started
RPCClient.js:323 HMI -> SDL [11:55:39:404]: {"jsonrpc":"2.0","method":"TTS.Started"}
UIRPC.js:1786 FFW.UI.UI.PerformInteractionResponse
UIRPC.js:1721 FFW.UI.PerformInteractionResponse
RPCClient.js:323 HMI -> SDL [11:55:41:430]: {"jsonrpc":"2.0","id":178,"error":{"code":10,"message":"UI.PerformInteraction has been timed out","data":{"method":"UI.PerformInteraction"}}}
TTSRPC.js:432 FFW.TTS.Stopped
RPCClient.js:323 HMI -> SDL [11:55:41:435]: {"jsonrpc":"2.0","method":"TTS.Stopped"}
UIRPC.js:2076 FFW.UI.OnSystemContext
RPCClient.js:323 HMI -> SDL [11:55:41:438]: {"jsonrpc":"2.0","method":"UI.OnSystemContext","params":{"systemContext":"MAIN","appID":1214726483}}
RPCClient.js:137 SDL -> HMI [11:55:45:767]: {"id":179,"jsonrpc":"2.0","method":"VR.PerformInteraction","params":{"appID":1214726483,"cancelID":0,"helpPrompt":[{"text":"Help prompt","type":"TEXT"}],"initialPrompt":[{"text":"Initial Prompt","type":"TEXT"}],"timeout":10000,"timeoutPrompt":[{"text":"Timeout prompt","type":"TEXT"}]}}
VRRPC.js:141 FFW.VR.onRPCRequest
TTSRPC.js:405 FFW.TTS.Started
RPCClient.js:323 HMI -> SDL [11:55:45:774]: {"jsonrpc":"2.0","method":"TTS.Started"}
VRRPC.js:373 FFW.VR.VR.PerformInteractionResponse
RPCClient.js:323 HMI -> SDL [11:55:45:777]: {"jsonrpc":"2.0","id":179,"result":{"code":0,"method":"VR.PerformInteraction"}}
RPCClient.js:137 SDL -> HMI [11:55:45:796]: {"id":180,"jsonrpc":"2.0","method":"UI.PerformInteraction","params":{"appID":1214726483,"cancelID":0,"choiceSet":[{"choiceID":1,"menuName":"Choice1"}],"initialText":{"fieldName":"initialInteractionText","fieldText":"Pick number:"},"interactionLayout":"ICON_ONLY","timeout":10000}}
UIRPC.js:157 FFW.UI.onRPCRequest
UIRPC.js:2076 FFW.UI.OnSystemContext
RPCClient.js:323 HMI -> SDL [11:55:45:800]: {"jsonrpc":"2.0","method":"UI.OnSystemContext","params":{"systemContext":"HMI_OBSCURED","appID":1214726483}}
TTSRPC.js:432 FFW.TTS.Stopped
RPCClient.js:323 HMI -> SDL [11:55:50:777]: {"jsonrpc":"2.0","method":"TTS.Stopped"}
TTSRPC.js:405 FFW.TTS.Started
RPCClient.js:323 HMI -> SDL [11:55:53:776]: {"jsonrpc":"2.0","method":"TTS.Started"}
UIRPC.js:1786 FFW.UI.UI.PerformInteractionResponse
UIRPC.js:1721 FFW.UI.PerformInteractionResponse
RPCClient.js:323 HMI -> SDL [11:55:55:804]: {"jsonrpc":"2.0","id":180,"error":{"code":10,"message":"UI.PerformInteraction has been timed out","data":{"method":"UI.PerformInteraction"}}}
TTSRPC.js:432 FFW.TTS.Stopped
RPCClient.js:323 HMI -> SDL [11:55:55:808]: {"jsonrpc":"2.0","method":"TTS.Stopped"}
UIRPC.js:2076 FFW.UI.OnSystemContext
RPCClient.js:323 HMI -> SDL [11:55:55:811]: {"jsonrpc":"2.0","method":"UI.OnSystemContext","params":{"systemContext":"MAIN","appID":1214726483}}

Environment:
SDL: https://github.com/smartdevicelink/sdl_core/tree/develop (69d57f2e)
HMI: https://github.com/smartdevicelink/sdl_hmi/tree/develop (c8744da)
SPT: 20210217-Android (1074)

@ShobhitAd
Copy link
Contributor

Closed via #570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants