-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.6.0 #626
Merged
Merged
Release 5.6.0 #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dly_message Don't send GetUserFriendlyMessage when app does not have specific permissions
* Add change to only trigger PTU on a SystemRequest if request type is PROPRIETARY * Handle response from external policy manager as a JSON object
also center close button, if present
Also adds restrictions for templates according to app type Homogenize `trackIcon` and `mainImage` in media and nonMedia models
…nse_format Use normal response format when sending sliderPosition
…ut_softbuttons_formatting Fix closeButton formatting for AlertManeuver
Fix switching between non-media and media templates
* Reset audioStreamingIndicator to PLAY_PAUSE if undefined in request * Address review comment * Reset audiostreamingIndicator to PLAY_PAUSE on HMI_NONE * Remove unused RPC case UI.SetAudioStreamingIndicator
* remove unnecessary MenuList setMode * Revert "remove unnecessary MenuList setMode" This reverts commit 2d43636. * fix console error with scrollable message change mode and add setMode call to scrollableMessage
…t_background Reset disabled buttons when app is deactivated
* Add TTS.Speak callbacks handlers and generic logic * Added postponed callback for UI.Alert * Added postponed callback for UI.SubtleAlert
…sponses (#583) Co-authored-by: Collin <co@ll.in>
* fixed HMI does not apply Display mode to the main screen image * Update app/view/media/sdl/controllsView.js Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> * Update app/view/media/sdl/controllsView.js Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> * Address Livio comments Co-authored-by: yurii <ypostolov> Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
…dule ID (#585) Co-authored-by: yurii <ypostolov>
* SLD-0189 Restructuring OnResetTimeout - Basic implementation of ResetTimeoutPopUp * Moved isEmptyObjectMethod to RCOntroller * SLD-0189 Restructuring OnResetTimeout - Updated ALertManeuverPopUp model - Updated AlertPopUp model - Updated SubtleAlertPopUp model - Updated TTSPopUp model * SLD-0189 Restructuring OnResetTimeout Updated RPC models * SLD-0189 Restructuring OnResetTimeout Updated InteractionChoicesView Models for PI requests * SLD-0189 Restructuring OnResetTimeout Added reset timeout input field * SLD-0189 Restructuring OnResetTimeout - Updated ScrollableMessage Model - Updated SliderView model * SLD-0189 Restructuring OnResetTimeout Minor fixes * SLD-0189 Restructuring OnResetTimeout Reset timeout to default if value in input field is out of bound * Add possibility to reset RC consent timeout * SDL-0189 Fixed OnClick for SubtleAlertPopUp * SDL-0189 Fixed TTS Start/Stopped * SDL-0189 Answer for review comments * SDL-0189 Refactoring ResetTimeoutPopUp * SDL-0189 Refactoring OnResetTimeout * SDL-0189 Answer for review comments * SDL-0189 Answer for review comments * SDL-0189 ScrollableMessage fix * SDL-0189 PerformInteraction refactor * SDL-0189 Fix Scrollable message * SDL-0189 Removed redundant check * SDL-189 Removed timeout decrement. Removed timeout decrement. Currently this logic implemented the SDL side * SDL-0189 Added originalTimeout value Added originalTimeout value to exclude case when the reset period is less than requested timeout * SDL-0189 Added check originalTimeout for resetTimeoutSpecificRpc method * SDL-189 Fixed of resetTimeoutSpecificRpc * SDL-0189 Added Keep Context processing for Alert and SubtleAlert * SDL-0189 Answer for review * SDL-0189 Answer for review comment Co-authored-by: valerii <valera.malkov@gmail.com> Co-authored-by: valerii <valera.malkof@gmail.com> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com> Co-authored-by: Valerii Malkov <VMalkov@luxoft.com>
* SDL-0192 Removed OnButtonSubscription notification from HMI * SDL-0192 Extended settings controller for apps to customize Subscribe button response result code * SDL-0192 Created separate file for button capabilities * SDL-0192 Updated RPC Helper * SDL-0192 Added SubscribeButton/UnsubscribeButton RPC's processing Co-authored-by: LitvinenkoIra <ilytvynenko@luxoft.com>
* fixed HMI does not apply Display mode to the main Alert image * address Livio comments Co-authored-by: yurii <ypostolov>
* Add changes to get capabilities based on template * Add changes to only send updated capabilities in OSCU * Rename function
…591) Co-authored-by: yurii <ypostolov>
…_RESOURCE result code (#594) Co-authored-by: yurii <ypostolov>
* Add comparator to track difference before and after And send OnIVD notification only for case when some fields has actually been changed. * Fix comparison result check
…#601) The reset timeout counter moved to the left side of the view
Co-authored-by: LiliiaShlikhtLuxoft <lshlikht@luxoft.com> Co-authored-by: Iryna Lytvynenko (GitHub) <ILytvynenko@luxoft.com>
…hin Alert and SubtitleAlert RPCs (#607)
* Fixed issue: HMI does not update the timeout for timeoutPrompt during timeout reseting * Fixed typo: timeoutPromprtCallback -> timeoutPromptCallback
…Layout(displayLayout = DEFAULT) for navigation app (#615)
…t is not closed by response sending (#614)
* Fixed issue: HMI Uncaught SyntaxError after processing SetDisplayLayout(displayLayout = DEFAULT) for media and non-media apps * Fixed issue: HMI Uncaught SyntaxError after processing SetDisplayLayout(displayLayout = DEFAULT) for media and non-media apps * Revert "Fixed issue: HMI Uncaught SyntaxError after processing SetDisplayLayout(displayLayout = DEFAULT) for media and non-media apps" This reverts commit 1897d6c. * Fixed issue after code review: Uncaught SyntaxError after processing SetDisplayLayout(displayLayout = DEFAULT) for media and non-media apps * Answer for review comments
…hing (#621) of Display mode and during active PerformInteraction
…up for timeout resetting (#623)
iCollin
approved these changes
Oct 8, 2021
…alert (#632) * Fixed regression issue: HMI does not wait timeout on button Reset timeout pressed during SubtleAlert processing * Refactored click event of SubtleAlertPopUp
jacobkeeler
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
[SDL 0192] Button Subscription response from HMI
[SDL 0189] Restructuring OnResetTimeout
Bug Fixes
HMI Uncaught SyntaxError after processing SetDisplayLayout(displayLayout = DEFAULT) for media and non-media apps
Extra lines in the empty sub menu list
Add missing languages to capabilities
HMI shall not send a OnInteriorVehicleData notification if a parameter is included in the request but the value is the same as the current value
HMI shows navigation buttons for all registered apps in case one of these apps has an active subscription
HMI does not update capabilities based on template
HMI does not apply Display mode to the main Alert image
ScrollableMessage Respond ABORTED on DEFAULT_ACTION or STEAL_FOCUS
HMI sends OnInteriorVehicleData notification without default moduleId
HMI does not apply display mode to the main screen image
HMI Uncaught ReferenceError during processing SetDisplayLayout(displayLayout = DEFAULT)
Cannot read property 'removeClass' of undefined
by switching ofDisplay mode
and during active ScrollableMessage and PerformInteractionHMI does not set default "PLAY_PAUSE" playback indicator in case App request SetMediaClockTimer without audioStreamingIndicator parameter
HMI sends invalid TTS.Speak response in case PerformInteraction has been requested without
Initial Prompt
HMI AlertManeuver pop-up is shown in case Navi.AlertManeuver request contains only appID
HMI applies the same display layout for Media and Non-media in case of layout setting via SetDisplayLayout
HMI sends SDL.OnReceivedPolicyUpdate for all SystemRequest request types
HMI sends GetUserFriendlyMessage with empty messageCodes