Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollable reply success on default action and steal focus #589

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Aug 11, 2021

Implements/Fixes #587

This PR is ready for review.

Testing Plan

described in issue

Summary

  • Change response of ScrollableMessage on both DEFAULT_ACTION and STEAL_FOCUS from ABORTED to SUCCESS
  • Adjust when to call ResetTimeoutPopUp.stopRpcProcessing('UI.ScrollableMessage');, so it will be called also on DEFAULT_ACTION and ABORTED

(this call is unnecessary in timeout case because timeout call is from ResetTimeoutPopUp when it has finished processing this RPC and behavior is already in effect)

CLA

@iCollin iCollin merged commit c9c4053 into develop Aug 12, 2021
@iCollin iCollin deleted the fix/scrollable_responses branch August 12, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants