Fixed HMI does not apply Display mode to the main Alert image #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShobhitAd
requested changes
Aug 11, 2021
css/sdl.css
Outdated
Comment on lines
1423
to
1424
| width: 80px; | ||
| height: 70px; |
There was a problem hiding this comment.
The ico-overlay doesn't cover the alertPopUpImage image since the ico-overlay is 80 x 70 and the alertPopUpImage has a maxwidth of 120
|
@Ypostolov please see the review feedback from Shobhit above. |
added 2 commits
August 17, 2021 00:02
…ot_apply_Display_mode_to_Alert_image
@ShobhitAd |
@jordynmackool |
ShobhitAd
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 516
This PR is ready for review.
Testing Plan
Mobile application is registered and activated, mobile app requests Alert( "AlertIcon" = { "value" = .png, "imageType" = "DYNAMIC", "isTemplate" = true }), than display mode changed, observe HMI applies display mode to the main Alert image.
Summary
Fixed HMI does not apply Display mode to the main Alert image.
CLA