Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMI AlertManeuver pop-up is shown in case Navi.AlertManeuver request contains only appID #536

Closed
VjKlepikov opened this issue Mar 23, 2021 · 3 comments

Comments

@VjKlepikov
Copy link
Contributor

VjKlepikov commented Mar 23, 2021

Description:
HMI AlertManeuver pop-up is shown in case Navi.AlertManeuver request contains only appID

Precondition:

  1. SDL and HMI are started
  2. Media mobile app is registered and activated

Steps to reproduce:

  1. Mobile app requests AlertManeuver RPC without softButtons

Expected result:
HMI does not show AlertManeuver pop-up, shows only TTS.Speak related to AlertManeuver request

Actual result:
HMI shows the empty AlertManeuver pop-up

Environment:
SDL: https://github.com/smartdevicelink/sdl_core/tree/7.1.0-RC1
HMI: https://github.com/smartdevicelink/sdl_hmi/tree/develop (7fad546)
SPT: SPT: 20210305-Android (1076)

@jacobkeeler jacobkeeler changed the title HMI AlertManeuver pop-up is shown in case Navi.AlertManeuveruver request contains only appID HMI AlertManeuver pop-up is shown in case Navi.AlertManeuver request contains only appID May 10, 2021
@jacobkeeler
Copy link
Contributor

jacobkeeler commented May 10, 2021

    <param name="softButtons" type="Common.SoftButton" minsize="0" maxsize="3" array="true" mandatory="false">
      <description>If omitted, only the system defined "Close" SoftButton should be displayed.</description>
    </param>

@VjKlepikov this looks like expected behavior (although I think that including some sort of info message would make it less confusing)

@jacobkeeler
Copy link
Contributor

I created a PR to make the layout look a little clearer in this case, see #565

@jacobkeeler
Copy link
Contributor

Closing with the merge of #565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants