Fix closeButton formatting for AlertManeuver #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also center close button, if present
Jack-Byrne
reviewed
May 13, 2021
| @@ -152,7 +149,8 @@ SDL.AlertManeuverPopUp = Em.ContainerView.create( | |||
| */ | |||
| addSoftButtons: function(params) { | |||
| const softButtons = params.softButtons; | |||
| if (!softButtons) { | |||
| if (!softButtons || softButtons.length == 0) { | |||
There was a problem hiding this comment.
I think the close button needs to be added if there are softbuttons included?
There was a problem hiding this comment.
I was following the existing behavior in this case, which was to only show the close button if app-defined buttons were not present. I think the current behavior at least matches the description in the API, though I do think it could be interpreted either way:
<param name="softButtons" type="SoftButton" minsize="0" maxsize="3" array="true" mandatory="false">
<description>If omitted on supported displays, only the system defined "Close" SoftButton shall be displayed.</description>
</param>
Jack-Byrne
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #536
This PR is ready for review.
Testing Plan
Send AlertManeuver without softbuttons, popup should appear with a centered "Close" button
Summary
Center close button when present in AlertManeuver popup
CLA