Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMI sends SDL.OnReceivedPolicyUpdate for all SystemRequest request types #560

Closed
ShobhitAd opened this issue Apr 21, 2021 · 1 comment · Fixed by #561
Closed

HMI sends SDL.OnReceivedPolicyUpdate for all SystemRequest request types #560

ShobhitAd opened this issue Apr 21, 2021 · 1 comment · Fixed by #561

Comments

@ShobhitAd
Copy link
Contributor

Description:

https://github.com/smartdevicelink/sdl_hmi/blob/develop/ffw/BasicCommunicationRPC.js#L597

if (request.method == 'BasicCommunication.SystemRequest') {
            if (FLAGS.ExternalPolicies === true) {
              FFW.ExternalPolicies.unpack({
                requestType: request.params.requestType,
                requestSubType: request.params.requestSubType,
                fileName: request.params.fileName
              });
            } else {
              this.OnReceivedPolicyUpdate(request.params.fileName);
            }
...

Precondition:

  1. HMI and SDL are started
  2. Mobile app is registered
  3. App is activated

Steps to reproduce:

  1. Send SystemRequest {requestType: "CLIMATE", fileName: "climateData.json"} from the mobile app

Expected result:

  1. HMI sends successful BasicCommunication.SystemRequest response to SDL
  2. Mobile app receives successful SystemRequest response

Actual result:

  1. HMI sends successful BasicCommunication.SystemRequest response to SDL
  2. HMI sends SDL.OnReceivedPolicyUpdate notification to SDL with {"policyfile":"/tmp/fs/mp/images/ivsu_cache/climateData.json"}
  3. Mobile app receives successful SystemRequest response

Environment:

SDL: smartdevicelink/sdl_core@08d1240
HMI: 71cbfe9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant