Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Only send OnReceivedPolicyUpdate for request type PROPRIETARY #561

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Fix/Only send OnReceivedPolicyUpdate for request type PROPRIETARY #561

merged 2 commits into from
Apr 21, 2021

Conversation

ShobhitAd
Copy link
Contributor

@ShobhitAd ShobhitAd commented Apr 21, 2021 •
edited
Loading

Implements/Fixes #560

This PR is ready for review.

Testing Plan

Run the following steps for both PROPRIETARY and EXTERNAL_PROPRIETARY

  1. Send SystemRequest {requestType: "CLIMATE", fileName: "climateData.json"} from the mobile app
  2. Confirm that HMI does NOT send SDL.OnReceivedPolicyUpdate with "climateData.json"

Core branch: https://github.com/smartdevicelink/sdl_core/tree/fix/return_requestype_in_sample_policy_manager_response

CLA

@ShobhitAd ShobhitAd changed the base branch from master to develop April 21, 2021 12:49
@ShobhitAd ShobhitAd merged commit 1832a4a into develop Apr 21, 2021
@ShobhitAd ShobhitAd deleted the fix/all_system_requests_triggering_ptu branch April 21, 2021 21:18
@ShobhitAd ShobhitAd mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCollin iCollin iCollin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HMI sends SDL.OnReceivedPolicyUpdate for all SystemRequest request types
2 participants
@ShobhitAd @iCollin